Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file related functions in the exclusion list of alternative functions rule #838

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Dec 18, 2024

Following functions are added in the exclusion list for alternative functions rule:

  • WordPress.WP.AlternativeFunctions.file_get_contents_file_get_contents
  • WordPress.WP.AlternativeFunctions.file_system_operations_file_put_contents

Above function calls are giving almost always false positives. So those should be reviewed manually.

@ernilambar ernilambar added [Type] Enhancement A suggestion for improvement of an existing feature [Team] Plugin Review Issues owned by Plugin Review Team labels Dec 18, 2024
@ernilambar ernilambar marked this pull request as ready for review December 18, 2024 09:44
Copy link

github-actions bot commented Dec 18, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: swissspidy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Team] Plugin Review Issues owned by Plugin Review Team [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants