Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error type of NonEnqueuedImage in ImageFunctions sniff #822

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Dec 9, 2024

Fixes #757

  • PluginCheck.CodeAnalysis.ImageFunctions.NonEnqueuedImage is now Warning instead of Error.

@ernilambar ernilambar marked this pull request as ready for review December 9, 2024 08:37
Copy link

github-actions bot commented Dec 9, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @wplaunchify.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: wplaunchify.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: sc0ttkclark <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar ernilambar changed the title Change error type of NonEnqueuedImage in image function sniff Change error type of NonEnqueuedImage in ImageFunctions sniff Dec 9, 2024
@ernilambar ernilambar added [Type] Bug An existing feature is broken [Team] Performance Issues owned by Performance Team labels Dec 9, 2024
@ernilambar ernilambar added this to the 1.4.0 milestone Dec 9, 2024
@mukeshpanchal27 mukeshpanchal27 merged commit f23a0b4 into trunk Dec 9, 2024
28 checks passed
@mukeshpanchal27 mukeshpanchal27 deleted the 757-image-functions branch December 9, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Team] Performance Issues owned by Performance Team [Type] Bug An existing feature is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images in plugin used with img get marked as errors
3 participants