Enhance: Improve pagination logic in core/query-pagination-previous block

[yogeshbhutkar]

Fixes: #67748

What?

The Query Pagination Previous block is displayed even when a user navigates beyond the range of available query results. Since no results are shown in such cases, displaying this block is unnecessary and can be confusing. This PR addresses the issue by ensuring the Query Pagination Previous block is hidden when the query has no results, improving user experience and interface clarity.

How?

The logic has been updated to render the block only when the page number is greater than 1 and less than or equal to the total number of pages, ensuring accurate and appropriate visibility.

Testing Instructions

1. Add a query loop block.
2. Make sure to add Query Pagination block which contains Query Pagination Previous Block as well.
3. Enter a page range that lies outside the query range.
4. Observe that the block Query Pagination Previous is not rendered.

Screencast

Screen.Recording.2024-12-10.at.10.47.05.AM.mov

Screenshots

Before:

After:

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <[email protected]>
Co-authored-by: michalczaplinski <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[yogeshbhutkar]

Requesting for a re-review from @ntsekouras as a follow-up to this closed PR.

[ntsekouras]

We should remove this extra line.

[ntsekouras]

The reason I suggested to move this block here is that we could avoid this if condition, since it's actually the else from above.

I know realized that we have an elseif ( 1 !== $page ), so I guess we could change the elseif to else, and inside that else block handle the if ( 1 !== $page ).

This way we wouldn't also need the temp assignment $total_pages = $max_page;

I hope I didn't confuse you :)