Make artifact names unique to each job in a matrix

[desrosj]

What?

This adds the part number to each artifact created in the End2End workflow.

Why?

After actions/upload-artifact was updated to version 4.x in #57111, the way artifacts are managed has changed. They are now uploaded on a per job basis and not per workflow. Read more on the release announcement.

The key thing to note here is that multiple jobs in the same run cannot upload to the same artifact.

It looks like all other workflows will not be affected by this because of how the matrix strategy is configured (only one job ever tries to upload an artifact with the same name).

[desrosj]

This needs a bit more work as the artifacts are downloaded later and processed in report-to-issues.

[kevin940726]

Thank you for working on this! I think we should try merging the final report-to-issues job but then it's good to go!

[kevin940726]

Seems like we can use the pattern input to download all artifacts in one step rather than splitting them into multiple parts.

[desrosj]

Thanks! Good spot, I missed those new options. I think this should be addressed now.

[desrosj]

@kevin940726 mind giving this another review and blessing when you have a chance?

[kevin940726]

Unfortunately, there's another breaking change I didn't see mentioned in the migration guide 😅. If we use the pattern field, the step outcome will still be success even though no data is downloaded. I guess we'll need an intermediate step to determine if any report is downloaded.

This can be a follow-up though. 👍

[kevin940726]

Thank you!

[desrosj]

Unfortunately, there's another breaking change I didn't see mentioned in the migration guide 😅. If we use the pattern field, the step outcome will still be success even though no data is downloaded. I guess we'll need an intermediate step to determine if any report is downloaded.

I wonder if we can use the download-path output from the action to check that an artifact was downloaded successfully. The documentation around that output is a bit scarce though. My thinking is using that in an if statement to check for an empty value, which we can use to assume nothing was downloaded.

I don't think there's any harm in adding that into this PR. I can do some experimenting later this week.

[kevin940726]

Based on the code at: https://github.com/actions/download-artifact/blob/f44cd7b40bfd40b6aa1cc1b9b5b7bf03d3c67110/src/download-artifact.ts#L125

It will still set the output even though it downloads nothing 😆. I think the only option we have is to add a bash script to check the emptiness of the directory right after the download-artifacts step.

[WunderBart]

Superseded by #61338.