Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions language reworked #13365

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nijel
Copy link
Member

@nijel nijel commented Dec 20, 2024

Proposed changes

Rest of changes from #12449 after splitting out #13364 and #13363.

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel nijel added this to the 5.10 milestone Dec 20, 2024
@nijel nijel requested a review from a team December 20, 2024 09:41
@nijel nijel force-pushed the permissions-language branch from 37b044d to fbd2efe Compare December 20, 2024 09:43
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.95%. Comparing base (c3b1e8d) to head (fbd2efe).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
weblate/auth/permissions.py 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #13365   +/-   ##
=======================================
  Coverage   90.95%   90.95%           
=======================================
  Files         604      604           
  Lines       62609    62609           
  Branches     6469     6469           
=======================================
+ Hits        56943    56946    +3     
+ Misses       3984     3982    -2     
+ Partials     1682     1681    -1     
Files with missing lines Coverage Δ
weblate/auth/permissions.py 90.51% <83.33%> (ø)

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants