Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

56-search-2.0 #82

Merged
merged 38 commits into from
Nov 12, 2023
Merged

56-search-2.0 #82

merged 38 commits into from
Nov 12, 2023

Conversation

VianneyMI
Copy link
Owner

@VianneyMI VianneyMI commented Nov 2, 2023 •
edited
Loading

Description

  • Fixed bug in Compound
  • Improved complex search experience

@VianneyMI
Fixed typo in wildcard
ea7449f
@VianneyMI
Deprecated old clause class and created a new one
382a4f5
@VianneyMI
Deprecated search_compound method in pipeline
85d7a9a
@VianneyMI
Working towards search 2.0
a0b1cbc 
- Renamed constructors as planned (i.e starts with init_<operator-name>
- Defined chainable methods using Compound in the background for Search
@VianneyMI
Use operators rather than statements in Compound
bd45f2d
@VianneyMI
WIP - Experimental - Refactored search
871435e 
- Created a search subpackage...
- ...gathering Search and SearchMeta classes
- Promote common behaviors in SearchConfig and SearchBase classes
@VianneyMI
Fixed test
33abafe
@VianneyMI VianneyMI added the enhancement New feature or request label Nov 2, 2023
@VianneyMI VianneyMI self-assigned this Nov 2, 2023
This was linked to issues Nov 2, 2023
search 2.0 #56
Closed
Compound search is almost unusable #48
Closed
@VianneyMI
Improve search/commons/count.py docstrings
5ba3609
@VianneyMI
Formatting
7d6f4a1
@VianneyMI
Improved Compound search
88f9ebc 
- Added missing more_like_this method
- Added possibility to chain on type of clause
@VianneyMI
Moved OperatorLiteral to operator module
c7f9778
@VianneyMI
Improved Search classes
8961af2 
- Added methods for must, should, etc.. clauses
- Improved docstrings
- Improved typing
@VianneyMI
Updated search test
6126442
@VianneyMI
Use CountOptions rather than raw dicts
56a89d0
@VianneyMI
Allow chainable search in pipeline
176948d
@VianneyMI
Upgraded mypy and fixed test on docstrings sync
ad37148
@VianneyMI
Bugfixes and cleaning
5fea2ab
@VianneyMI
Added unused kwargs in SearchBase operators functions
acd3ec2 
- to avoid that they break if they receive unrecognized keyword arguments
@VianneyMI
Bugfixes in Compound
dc3e2af 
- Improved Pipeline, Search and Compound interactions
@VianneyMI
Bugfixes in compound
0fb0bb7
@VianneyMI
Allow access to operators through Search classes
745eff1
@VianneyMI
Upgrading Facet
cd4e9c3
@VianneyMI
Added facets constructors and Facet interface
a3b3e61
@VianneyMI
Clarifying use of facets
85afa34
@VianneyMI
Bugfix in SearchMeta statement
85d5428
@VianneyMI
Debugging search_meta through pipeline
8ac1caa
@VianneyMI VianneyMI marked this pull request as ready for review November 6, 2023 20:14
@VianneyMI
Updated search operators in Search class..
6d1e477 
- ... to take into account Faceted Search
- Replaced Compound as default operator...
- ... by Facet collector with  Compound operator => TO BE IMPROVED
@VianneyMI
Created useful mappings and type aliases
3184aff
@VianneyMI
Refactored search and search_meta pipeline methods
e675151 
- Ensured better sync between the two.
- Ease process of using faceted search through pipeline.
@VianneyMI
Testing and debugging.
5a95f18 
Looks stable
@VianneyMI
Added tests on compound search
d1022a3
@VianneyMI
Added facet examples
6340444
@VianneyMI
Added changelog
a6e3610
@VianneyMI
bump version 0.17.0 -> 0.18.0
d0068f9
@VianneyMI VianneyMI merged commit 5aa019e into main Nov 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VianneyMI VianneyMI

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

search 2.0 Compound search is almost unusable
1 participant
@VianneyMI