72 expressions improvements #117

VianneyMI · 2024-04-21T12:33:00Z

No description provided.

github-actions · 2024-04-21T12:33:26Z

tests/test_stages.py

@@ -61,7 +61,7 @@ def test_stage(self)->None:

        with pytest.raises(TypeError):
            # Checking that Stage cannot be instantiated
-            stage = Stage(statement={})  # pylint: disable=abstract-class-instantiated
+            stage = Stage(expression={})  # pylint: disable=abstract-class-instantiated


[Ruff] _{reported by reviewdog 🐶}
F841 Local variable stage is assigned to but never used

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

mypy

src/monggregate/operators/objects/merge_objects.py|74 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/comparison/ne.py|63 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/comparison/lte.py|62 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/comparison/lt.py|61 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/comparison/gte.py|61 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/comparison/gt.py|62 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/comparison/eq.py|66 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/comparison/cmp.py|68 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/boolean/or_.py|59 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/boolean/not_.py|58 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/boolean/and_.py|82 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/array/sort_array.py|127 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/array/size.py|58 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/array/min_n.py|73 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/array/max_n.py|74 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/array/last.py|130 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/array/is_array.py|51 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/array/in_.py|69 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/array/first.py|120 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/array/filter.py|114 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/array/array_to_object.py|96 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/accumulators/sum.py|128 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/accumulators/push.py|62 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/accumulators/min.py|119 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/accumulators/max.py|119 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/accumulators/last.py|90 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/accumulators/first.py|97 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/accumulators/count.py|75 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/accumulators/avg.py|110 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/stages/bucket_auto.py|171 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/stages/bucket.py|123 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/search/operators/autocomplete.py|176 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/strings/date_to_string.py|130 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/strings/date_from_string.py|122 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/strings/concat.py|56 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/date/millisecond.py|186 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/conditional/switch.py|104 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/conditional/if_null.py|80 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/conditional/cond.py|143 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/arithmetic/subtract.py|77 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/arithmetic/pow.py|77 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/arithmetic/multiply.py|56 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/arithmetic/divide.py|61 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/arithmetic/add.py|57 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/search/operators/compound.py|127 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/search/collectors/facet.py|279 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/search/collectors/facet.py|304 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/search/collectors/facet.py|326 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/search/collectors/facet.py|392 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/stages/search/search_meta.py|121 col 23| Item "None" of "Facet | Autocomplete | Compound | Equals | Exists | MoreLikeThis | Range | Regex | Text | Wildcard | None" has no attribute "expression" [union-attr]
src/monggregate/stages/search/search_meta.py|127 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[str, dict[Any, Any]]") [return-value]
src/monggregate/stages/search/search.py|131 col 23| Item "None" of "Facet | Autocomplete | Compound | Equals | Exists | MoreLikeThis | Range | Regex | Text | Wildcard | None" has no attribute "expression" [union-attr]
src/monggregate/stages/search/search.py|137 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[str, dict[Any, Any]]") [return-value]
src/monggregate/pipeline.py|115 col 5| Signature of "expression" incompatible with supertype "BaseModel" [override]
src/monggregate/pipeline.py|115 col 5| Superclass:
src/monggregate/pipeline.py|115 col 5| dict[Any, Any]
src/monggregate/pipeline.py|115 col 5| Subclass:
src/monggregate/pipeline.py|115 col 5| list[dict[Any, Any]]
src/monggregate/pipeline.py|118 col 17| List comprehension has incompatible type List[dict[Any, Any] | dict[str, dict[Any, Any]] | Any | None]; expected List[dict[Any, Any]] [misc]
tests/test_stages.py|64 col 21| Cannot instantiate abstract class "Stage" with abstract attribute "expression" [abstract]

github-actions · 2024-04-21T12:33:56Z

src/monggregate/base.py

+    def to_expression(self)->dict:
+        """Converts an instance of a class inheriting from BaseModel to an expression"""
+
+        return self.express(self)


🚫 [mypy] _{reported by reviewdog 🐶}
Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]

github-actions · 2024-04-21T12:33:56Z

src/monggregate/base.py

@@ -49,7 +54,7 @@
    def __call__(self)->dict:
        """Makes an instance of any class inheriting from this class callable"""

-        return self.resolve(self.statement)
+        return self.express(self.expression)


🚫 [mypy] _{reported by reviewdog 🐶}
Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]

github-actions · 2024-04-21T12:33:56Z

src/monggregate/search/commons/fuzzy.py


-        return self.resolve(self.dict(by_alias=True))
+        return self.express(self.dict(by_alias=True))


🚫 [mypy] _{reported by reviewdog 🐶}
Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]

github-actions · 2024-04-21T12:33:56Z

src/monggregate/search/commons/count.py


-        return self.resolve(self.dict(by_alias=True))
+        return self.express(self.dict(by_alias=True))


🚫 [mypy] _{reported by reviewdog 🐶}
Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]

github-actions · 2024-04-21T12:33:56Z

src/monggregate/search/commons/count.py


-        return self.resolve(self.dict(by_alias=True))
+        return self.express(self.dict(by_alias=True))


🚫 [mypy] _{reported by reviewdog 🐶}
Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]

github-actions · 2024-04-21T12:33:58Z

src/monggregate/search/operators/range.py

@@ -127,5 +127,5 @@ def statement(self) -> dict:
            else:
                params["lte"] = self.lte

-            return self.resolve({"range":params})
+            return self.express({"range":params})


🚫 [mypy] _{reported by reviewdog 🐶}
Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]

github-actions · 2024-04-21T12:33:58Z

src/monggregate/search/operators/more_like_this.py


-        return self.resolve({
+        return self.express({


🚫 [mypy] _{reported by reviewdog 🐶}
Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]

github-actions · 2024-04-21T12:33:58Z

src/monggregate/search/operators/exists.py


-        return self.resolve({
+        return self.express({


🚫 [mypy] _{reported by reviewdog 🐶}
Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]

github-actions · 2024-04-21T12:33:58Z

src/monggregate/search/operators/equals.py


-            return self.resolve({
+            return self.express({


🚫 [mypy] _{reported by reviewdog 🐶}
Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]

github-actions · 2024-04-21T12:33:58Z

src/monggregate/operators/objects/object_to_array.py

-    def statement(self) -> dict:
-        return self.resolve({
+    def expression(self) -> dict:
+        return self.express({


🚫 [mypy] _{reported by reviewdog 🐶}
Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

mypy

src/monggregate/stages/bucket.py|123 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/search/operators/autocomplete.py|176 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/strings/date_to_string.py|130 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/strings/date_from_string.py|122 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/strings/concat.py|56 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/date/millisecond.py|186 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/conditional/switch.py|104 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/conditional/if_null.py|80 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/conditional/cond.py|143 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/arithmetic/subtract.py|77 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/arithmetic/pow.py|77 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/arithmetic/multiply.py|56 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/arithmetic/divide.py|61 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/operators/arithmetic/add.py|57 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/search/operators/compound.py|127 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/expressions.py|287 col 39| Unexpected keyword argument "operand" for "MaxN" [call-arg]
src/monggregate/expressions.py|287 col 39| Unexpected keyword argument "limit" for "MaxN" [call-arg]
src/monggregate/expressions.py|294 col 39| Unexpected keyword argument "operand" for "MinN" [call-arg]
src/monggregate/expressions.py|294 col 39| Unexpected keyword argument "limit" for "MinN" [call-arg]
src/monggregate/expressions.py|308 col 39| Unexpected keyword argument "operand" for "SortArray" [call-arg]
src/monggregate/expressions.py|308 col 39| Unexpected keyword argument "by" for "SortArray" [call-arg]
src/monggregate/expressions.py|442 col 39| Unexpected keyword argument "operand" for "Switch" [call-arg]
src/monggregate/expressions.py|451 col 39| Missing named argument "timezone" for "Millisecond" [call-arg]
src/monggregate/expressions.py|483 col 39| Unexpected keyword argument "operand" for "DateFromString" [call-arg]
src/monggregate/expressions.py|490 col 39| Unexpected keyword argument "operand" for "DateToString" [call-arg]
src/monggregate/search/collectors/facet.py|279 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/search/collectors/facet.py|304 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/search/collectors/facet.py|326 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/search/collectors/facet.py|392 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]
src/monggregate/stages/search/search_meta.py|121 col 23| Item "None" of "Facet | Autocomplete | Compound | Equals | Exists | MoreLikeThis | Range | Regex | Text | Wildcard | None" has no attribute "expression" [union-attr]
src/monggregate/stages/search/search_meta.py|127 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[str, dict[Any, Any]]") [return-value]
src/monggregate/stages/search/search.py|131 col 23| Item "None" of "Facet | Autocomplete | Compound | Equals | Exists | MoreLikeThis | Range | Regex | Text | Wildcard | None" has no attribute "expression" [union-attr]
src/monggregate/stages/search/search.py|137 col 16| Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[str, dict[Any, Any]]") [return-value]
src/monggregate/pipeline.py|115 col 5| Signature of "expression" incompatible with supertype "BaseModel" [override]
src/monggregate/pipeline.py|115 col 5| Superclass:
src/monggregate/pipeline.py|115 col 5| dict[Any, Any]
src/monggregate/pipeline.py|115 col 5| Subclass:
src/monggregate/pipeline.py|115 col 5| list[dict[Any, Any]]
tests/test_stages.py|64 col 21| Cannot instantiate abstract class "Stage" with abstract attribute "expression" [abstract]

github-actions · 2024-04-21T13:29:52Z

src/monggregate/operators/objects/merge_objects.py

-        return self.resolve({
-            "$mergeObjects" : self.expression
+    def expression(self) -> dict:
+        return self.express({


🚫 [mypy] _{reported by reviewdog 🐶}
Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]

github-actions · 2024-04-21T13:29:52Z

src/monggregate/operators/comparison/ne.py


-        return self.resolve({
+        return self.express({


🚫 [mypy] _{reported by reviewdog 🐶}
Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]

github-actions · 2024-04-21T13:29:53Z

src/monggregate/operators/comparison/lte.py


-        return self.resolve({
+        return self.express({


🚫 [mypy] _{reported by reviewdog 🐶}
Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]

github-actions · 2024-04-21T13:29:53Z

src/monggregate/operators/comparison/lt.py


-        return self.resolve({
+        return self.express({


🚫 [mypy] _{reported by reviewdog 🐶}
Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]

github-actions · 2024-04-21T13:29:53Z

src/monggregate/operators/comparison/gte.py


-        return self.resolve({
+        return self.express({


🚫 [mypy] _{reported by reviewdog 🐶}
Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]

github-actions · 2024-04-21T13:29:55Z

src/monggregate/operators/accumulators/last.py


-        return self.resolve({
-            "$last" : self.expression
+        return self.express({


🚫 [mypy] _{reported by reviewdog 🐶}
Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]

github-actions · 2024-04-21T13:29:55Z

src/monggregate/operators/accumulators/first.py


-        return self.resolve({
-            "$first" : self.expression
+        return self.express({


🚫 [mypy] _{reported by reviewdog 🐶}
Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]

github-actions · 2024-04-21T13:29:55Z

src/monggregate/operators/accumulators/count.py


-        return self.resolve({
+        return self.express({


🚫 [mypy] _{reported by reviewdog 🐶}
Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]

github-actions · 2024-04-21T13:29:55Z

src/monggregate/operators/accumulators/avg.py


-        return self.resolve({
-            "$avg" : self.expression
+        return self.express({


🚫 [mypy] _{reported by reviewdog 🐶}
Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]

github-actions · 2024-04-21T13:29:55Z

src/monggregate/stages/bucket_auto.py


      # NOTE : maybe it would be better to use _to_unique_list here
      # or to further validate by.
-      return   self.resolve({
+      return   self.express({


🚫 [mypy] _{reported by reviewdog 🐶}
Incompatible return value type (got "dict[Any, Any] | list[dict[Any, Any]]", expected "dict[Any, Any]") [return-value]

…ollection removal in pipeline

github-actions · 2024-04-21T19:59:26Z

src/monggregate/stages/stage.py

@@ -2,17 +2,29 @@

 # Standard Library imports
 #----------------------------
-from abc import ABC
+from abc import ABC, abstractmethod


[Ruff] _{reported by reviewdog 🐶}
F401 [*] abc.abstractmethod imported but unused

VianneyMI added 3 commits April 21, 2024 14:08

Renamed statement as expression

eb0e438

Renamed expression as operand

0a6423f

Renamed resolve as express

62df4fa

VianneyMI linked an issue Apr 21, 2024 that may be closed by this pull request

Expressions improvements #72

Closed

github-actions bot reviewed Apr 21, 2024

View reviewed changes

VianneyMI added 3 commits April 21, 2024 14:47

expression -> operand

2be2269

follow up

fd11302

Fixed tests

5acd247

github-actions bot reviewed Apr 21, 2024

View reviewed changes

VianneyMI added 6 commits April 21, 2024 20:36

Added mypy.ini and updated gitignore

dae70a6

Replaced old dict typehints by Expression

e89aa5f

Follow up

2184d36

Replaced dict typehint by Expression in operators

2136f91

Follow up for search operators

e3b7cab

FIXME : Fix lookup, join, right join and associated tests following c…

b587cec

…ollection removal in pipeline

github-actions bot reviewed Apr 21, 2024

View reviewed changes

VianneyMI added 4 commits April 22, 2024 22:56

Removed right joins

6dc45d8

Removed old expressions module

badad53

Merge branch 'main' into 72-expressions-improvements

b1256f4

Fixed test

91d4d8b

VianneyMI marked this pull request as ready for review April 23, 2024 20:42

VianneyMI merged commit 3bb0933 into main Apr 23, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

72 expressions improvements #117

72 expressions improvements #117

VianneyMI commented Apr 21, 2024

github-actions bot Apr 21, 2024

github-actions bot left a comment

github-actions bot Apr 21, 2024

github-actions bot Apr 21, 2024

github-actions bot Apr 21, 2024

github-actions bot Apr 21, 2024

github-actions bot Apr 21, 2024

github-actions bot Apr 21, 2024

github-actions bot Apr 21, 2024

github-actions bot Apr 21, 2024

github-actions bot Apr 21, 2024

github-actions bot Apr 21, 2024

github-actions bot left a comment

github-actions bot Apr 21, 2024

github-actions bot Apr 21, 2024

github-actions bot Apr 21, 2024

github-actions bot Apr 21, 2024

github-actions bot Apr 21, 2024

github-actions bot Apr 21, 2024

github-actions bot Apr 21, 2024

github-actions bot Apr 21, 2024

github-actions bot Apr 21, 2024

github-actions bot Apr 21, 2024

github-actions bot Apr 21, 2024


		return self.resolve(self.dict(by_alias=True))
		return self.express(self.dict(by_alias=True))

72 expressions improvements #117

72 expressions improvements #117

Conversation

VianneyMI commented Apr 21, 2024

github-actions bot Apr 21, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Apr 21, 2024

Choose a reason for hiding this comment

github-actions bot Apr 21, 2024

Choose a reason for hiding this comment

github-actions bot Apr 21, 2024

Choose a reason for hiding this comment

github-actions bot Apr 21, 2024

Choose a reason for hiding this comment

github-actions bot Apr 21, 2024

Choose a reason for hiding this comment

github-actions bot Apr 21, 2024

Choose a reason for hiding this comment

github-actions bot Apr 21, 2024

Choose a reason for hiding this comment

github-actions bot Apr 21, 2024

Choose a reason for hiding this comment

github-actions bot Apr 21, 2024

Choose a reason for hiding this comment

github-actions bot Apr 21, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Apr 21, 2024

Choose a reason for hiding this comment

github-actions bot Apr 21, 2024

Choose a reason for hiding this comment

github-actions bot Apr 21, 2024

Choose a reason for hiding this comment

github-actions bot Apr 21, 2024

Choose a reason for hiding this comment

github-actions bot Apr 21, 2024

Choose a reason for hiding this comment

github-actions bot Apr 21, 2024

Choose a reason for hiding this comment

github-actions bot Apr 21, 2024

Choose a reason for hiding this comment

github-actions bot Apr 21, 2024

Choose a reason for hiding this comment

github-actions bot Apr 21, 2024

Choose a reason for hiding this comment

github-actions bot Apr 21, 2024

Choose a reason for hiding this comment

github-actions bot Apr 21, 2024

Choose a reason for hiding this comment