Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal/2022.3/staging #8115

Merged
merged 16 commits into from
Dec 18, 2024
Merged

Internal/2022.3/staging #8115

merged 16 commits into from
Dec 18, 2024

Conversation

UnityAljosha
Copy link
Collaborator

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?


Testing status

Describe what manual/automated tests were performed for this PR


Comments to reviewers

Notes for the reviewers you have assigned.

UUM-70926

With HDR disabled, the UI is rendered only from the main camera. With HDR enabled, UI rendering occurs from all cameras.

RawImage can use a render texture as a source. Each camera that outputs to a render texture references the unprocessed texture when rendering the UI. This causes corrupted rendering.

Changed the UI to be rendered only on the main camera.
…U'S if …

Issue : https://jira.unity3d.com/browse/UUM-82949
Camera view is not rendered on PowerVR Rogue GE8320 GPU'S if Shadows are enabled in URP Asset and Camera stack contains Overlay Camera's. This is caused by changes done to fix https://jira.unity3d.com/browse/UUM-59572

These changes are now being reverted. There is a PR in trunk which fixes original bug (UUM-59572) without needing the fix that is now being reverted.
To update test images for consoles
Fixed the size of the reflection probe texture cache in the test suite to prevent out of memory error
Jira: https://jira.unity3d.com/browse/UUM-76254

Group position is adjusted as elements are added to it. However, if the group is empty, its position remains unchanged and is pasted at the original location. This has been fixed so that the group's position is adjusted when pasting, even if the group is empty.

While fixing this issue, I discovered and resolved a problem where the position of a newly created group was not being set initially


Before
![Before](https://media.github.cds.internal.unity3d.com/user/761/files/2a5877b8-75ae-4944-8290-f21ae3dfa098)

After
![After](https://media.github.cds.internal.unity3d.com/user/761/files/0dbdf1f9-f095-4c5f-bfb9-c23f406c7576)
…tencil shadows

Add documentation for how shadow matte interacts with stencil and ray traced shadows.

The 'regression' happened when Anis added stencil for unlit materials https://github.cds.internal.unity3d.com/unity/unity/pull/16463/files#diff-f8f08e5234e1f79654d09936f18d3a903cdb9eccf0ab92b29d8e377a24c66845. The user can check Shadow Matte on the custom shader graph and it will work again. 

https://jira.unity3d.com/browse/UUM-72348
… used with Pixel Perfect Camera

Fix UUM-51358
Fixed the CameraDepthAttachment Texture for Dx11, which was rendering as black earlier.
The issue is the Camera Depth Attachment texture is referring to the depth buffer and when the shader is trying to access the texture the texture is black

Bug: https://jira.unity3d.com/browse/UUM-64316
Backport: https://jira.unity3d.com/browse/UUM-65831
…ation

DOCG-5973 updated the linear gradient image (shows the correct linear gradient now), edited the caption.

DOCG-4959 VFX code snippet "position" capitalization fix.
…a (Volume Mask, Layers)

Fixed the description about post-processing effects affecting a camera (Volume Mask, Layers)
I made a fix for https://jira.unity3d.com/browse/UUM-68986 that was too aggressive - clearing the material property block after each blit actually clears properties that are needed between blits, in the case for example of edge detection. This created another bug (https://jira.unity3d.com/browse/UUM-85970) where TexelSize property was cleared between two blits in the same pass.

Luckily, in the meantime, a better fix was implemented in Unity 6 and 7 (#51608). This PR backports it to 2022.3 (after talking to the original owner, there's should be no reason not to backport it)
This works better because it doesn't clear property blocks after each blit, only when a RenderTargetIdentifier is used, which is less aggressive than the fix I had in the first place
…ispose

DOCG-5914 added an extra null check,
DOCG-5912 protected access for Dispose
…nt point in performance impact.

[Backport of pull/57437] DOCG-4814. Clarified the rendering layer count point in performance impact.
@UnityAljosha UnityAljosha requested review from a team as code owners December 18, 2024 09:27
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@UnityAljosha UnityAljosha merged commit c757aae into 2022.3/staging Dec 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants