Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bitnami postgres installation link #5768

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

munkiat
Copy link
Contributor

@munkiat munkiat commented Nov 29, 2024

Currently copying the link from docs directly gives the following helm install tyk-postgres bitnami/postgresql --set "auth.database=tyk_analytics" -n tyk --version 12.12.10 Error: INSTALLATION FAILED: repo bitnami not found

Edited to use the helm install link from https://github.com/bitnami/charts/tree/main/bitnami/postgresql

For internal users - Please add a Jira DX PR ticket to the subject!



Preview Link


Description


Screenshots (if appropriate)


Checklist

  • I have added a preview link to the PR description.
  • I have reviewed the suggestions made by our AI (PR Agent) and updated them accordingly (spelling errors, rephrasing, etc.)
  • I have reviewed the guidelines for contributing to this repository.
  • I have read the technical guidelines for contributing to this repository.
  • Make sure you have started your change off our latest master.
  • I labeled the PR

Currently copying the link from docs directly gives the following 
helm install tyk-postgres bitnami/postgresql --set "auth.database=tyk_analytics" -n tyk --version 12.12.10
Error: INSTALLATION FAILED: repo bitnami not found

Edited to use the helm install link from https://github.com/bitnami/charts/tree/main/bitnami/postgresql
Copy link

netlify bot commented Nov 29, 2024

👷 Deploy request for tyk-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9ff5191

@@ -290,7 +290,7 @@ global:

**PostgresSQL Installation**
```bash
helm install tyk-postgres bitnami/postgresql --set "auth.database=tyk_analytics" -n tyk --version 12.12.10
helm install tyk-postgres oci://registry-1.docker.io/bitnamicharts/postgresql --set "auth.database=tyk_analytics" -n tyk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
helm install tyk-postgres oci://registry-1.docker.io/bitnamicharts/postgresql --set "auth.database=tyk_analytics" -n tyk
helm install tyk-postgres oci://registry-1.docker.io/bitnamicharts/postgresql --set "auth.database=tyk_analytics" -n tyk --version 16.2.3

I think we should restrict to the current version of chart, Have you tested with this version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sharadregoti yes makes sense. I've used the latest; not sure if our automated tests uses v16.2.3 exactly. Would something like v15 work? https://tyk.io/docs/planning-for-production/database-settings/postgresql/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

16.2.3 is the helm chart version. In this chart version the default value for postgres is 17.2.0-debian-12-r2. We need to select a chart version which uses postgres version 16.x or 15.x as per this page.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or alternatively we can fixate on chat version 16.2.3 and set the image version --set image.tag="16.6.0"
I used this postgres version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants