Refactored boot time / on demand asset generation #21866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike182uk
force-pushed
the
mike-onc-662-fix-file-write-issues-in-ghost-application-related-to-asset-2
branch
6 times, most recently
from
6cf4c9d to
ceb9ad9
Compare
mike182uk
changed the title
mike182uk
force-pushed
the
mike-onc-662-fix-file-write-issues-in-ghost-application-related-to-asset-2
branch
3 times, most recently
from
e48ee21 to
7960d6b
Compare
mike182uk
changed the title
mike182uk
force-pushed
the
mike-onc-662-fix-file-write-issues-in-ghost-application-related-to-asset-2
branch
2 times, most recently
from
173a2e5 to
6ead434
Compare
mike182uk
commented
Dec 16, 2024
| @@ -22,7 +22,9 @@ | |||
| "scripts": { | |||
| "archive": "npm pack", | |||
| "dev": "node --watch index.js", | |||
| "build:assets": "postcss core/frontend/public/ghost.css --no-map --use cssnano -o core/frontend/public/ghost.min.css", | |||
| "build:assets:css": "postcss core/frontend/public/ghost.css --no-map --use cssnano -o core/frontend/public/ghost.min.css", | |||
| "build:assets:js": "../minifier/bin/minify core/frontend/public/comment-counts.js core/frontend/public/comment-counts.min.js && ../minifier/bin/minify core/frontend/public/member-attribution.js core/frontend/public/member-attribution.min.js && ../minifier/bin/minify core/frontend/public/admin-auth/message-handler.js core/frontend/public/admin-auth/admin-auth.min.js", | |||
There was a problem hiding this comment.
@daniellockyer Any thoughts on this?
mike182uk
commented
Dec 16, 2024
| }, serveStatic( | ||
| path.join(config.getContentPath('public'), 'admin-auth') | ||
| )); | ||
| }, createServeAuthFrameFileMw(config, urlUtils)); |
There was a problem hiding this comment.
Had to switch to using a custom middleware as express/serve-static does not allow us to hook into the response body to perform the necessary placeholder replacements
mike182uk
commented
Dec 16, 2024
| @@ -56,29 +53,3 @@ describe('vhost utils', function () { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('getContentPath', function () { | |||
There was a problem hiding this comment.
No longer needed as we are reverting the changes added here
mike182uk
force-pushed
the
mike-onc-662-fix-file-write-issues-in-ghost-application-related-to-asset-2
branch
from
6ead434 to
0d7846d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs ONC-662
Refactored the generation of the following assets:
comment-counts.jsmember-attribution.jsadmin-authto occur at build time instead of at boot time or on demand
cardsare still built on demand as these assets need to be re-generated when a theme changes - we utilise the existing asset minification system for this, except we only execute the middleware responsible for this when a request is for a card asset (instead of any path, which is a bug in the current implementation)This also reverts the changes made in #21857 as these changes are no longer needed (because the assets are now generated at build time)