Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Line2): allow points to be added/removed, fix defineExpose ref #523

Closed
wants to merge 4 commits into from

Conversation

andretchen0
Copy link
Contributor

@andretchen0 andretchen0 commented Nov 18, 2024

Problem

After initial creation, additional points could not be added to Cientos' Line2 component. The on-screen component would not display the additional points.

Solution

Recreate the Line2 geometry to accommodate the additional points.

Problem

The defineExposed instance is undefined because here ...

<template>
  <primitive
    :ref="lineRef"
    :object="line"
  />
</template>

... :ref should be ref.

Solution

Remove the colon from :ref.

Meta

Closes #493

Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for cientos-tresjs failed. Why did it fail? →

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/cientos-tresjs/deploys/674df2e97b072b00912224c0

@andretchen0 andretchen0 added bug Something isn't working p3-minor-bug An edge case that only affects very specific usage (priority) labels Nov 23, 2024
Copy link

pkg-pr-new bot commented Nov 24, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@tresjs/cientos@523

commit: 0a2b57e

@andretchen0 andretchen0 changed the title feat(Line2): allow points to be added/removed fix(Line2): allow points to be added/removed Nov 28, 2024
@andretchen0 andretchen0 changed the title fix(Line2): allow points to be added/removed fix(Line2): allow points to be added/removed, fix defineExpose ref Nov 28, 2024
@andretchen0 andretchen0 mentioned this pull request Nov 28, 2024
@andretchen0
Copy link
Contributor Author

Mysterious Netlify errors here. Seemingly unrelated to the PR, according to the Netlify build logs. Closing and resubmitting a new PR.

@andretchen0 andretchen0 closed this Dec 2, 2024
@andretchen0 andretchen0 deleted the feat/line2-length branch December 2, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Line2,Modify props.points, but it does not take effect
2 participants