Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump roborazzi from 1.34.0 to 1.37.0 #2169

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 16, 2024

Bumps roborazzi from 1.34.0 to 1.37.0.
Updates io.github.takahirom.roborazzi:roborazzi-gradle-plugin from 1.34.0 to 1.37.0

Release notes

Sourced from io.github.takahirom.roborazzi:roborazzi-gradle-plugin's releases.

1.37.0

Bug Fixes and Workarounds

Compose AlertDialog Support

Support for capturing Alert Dialogs has been fixed, ensuring correct screenshot display. captureScreenRoboImage(), which merges all windows, is now used only when multiple windows are present. Thanks to @​ashughes for reporting this and to @​mhidaka and @​hiroaki404 for bringing it to my attention at a Japan Android testing event.

Workaround for Overlap Handling for SDK 35 Compose Screenshots

Problem

When updating to SDK 35 and using the default theme, the ActionBar is included in screenshots, leading to overlap when using createComposeRule(). This occurs because createComposeRule() uses the default theme by default. Thank you for letting me know about this, @​keyboardsurfer!

I have filed an issue for this: https://issuetracker.google.com/issues/383368165

Why this happens

SDK 35 enforces edge-to-edge display, which means it does not provide automatic padding for the ActionBar.

How Roborazzi currently workarounds this

Roborazzi now automatically hides the ActionBar when taking screenshots on SDK 35 and higher. This functions similarly to view.getActivity()?.actionBar?.hide(). However, this workaround may cause performance issues and should not be relied upon. Roborazzi outputs warning logs with alternative suggestions. Thank you to @​sergio-sastre for advising on this workaround!

If you need to include the ActionBar in screenshots, Roborazzi provides a flag, roborazzi.compose.actionbar.overlap.fix=false, that can be added to your gradle.properties file.

What should we do?

A permanent solution will likely require changes from Google. In the meantime, adding <application android:theme="@style/Theme.AppCompat.Light.NoActionBar" /> to the module's src/test/AndroidManifest.xml file changes the Activity's default theme and resolves the issue. Thank you to @​mattinger for finding this!

takahirom/roborazzi#598

Stabilized Output for Dump Screenshots

Thanks to @​siarhei-luskanau for contributing an improvement that reduces unnecessary diffs for the Roborazzi dump feature.

New Features

Add inspectionMode() for Compose Previews

Thanks to @​YusukeMoriJapan's contribution, inspectionMode() is now available in RoborazziComposeOptions. This is particularly useful when working with libraries that have specific preview implementations. This mode is off by default to maintain high fidelity.

Here's how to enable it:

captureRoboImage(
</tr></table> 

... (truncated)

Commits
  • 297a715 Merge pull request #610 from takahirom/takahirom/fix-name-of-inspectionMode/2...
  • b21d5d3 Fix name of inspectionMode
  • c9d0185 1.37.0
  • c904c1d Merge pull request #604 from takahirom/takahirom/add-workaround-for-overlap/2...
  • 7382573 Merge branch 'main' into takahirom/add-workaround-for-overlap/2024-12-12
  • f508092 Merge pull request #609 from takahirom/takahirom/revert-compileSdk-and-target...
  • 1f82d36 Revert compileSdk and targetSdk for library
  • 4f7ef54 Merge pull request #603 from takahirom/takahirom/add-default-theme-test/2024-...
  • 371cce6 Merge pull request #555 from takahirom/takahirom/add-alertdialog-test/2024-11-15
  • afe80c0 Fix to use actionBar.hide() to do workaround
  • Additional commits viewable in compare view

Updates io.github.takahirom.roborazzi:roborazzi from 1.34.0 to 1.37.0

Release notes

Sourced from io.github.takahirom.roborazzi:roborazzi's releases.

1.37.0

Bug Fixes and Workarounds

Compose AlertDialog Support

Support for capturing Alert Dialogs has been fixed, ensuring correct screenshot display. captureScreenRoboImage(), which merges all windows, is now used only when multiple windows are present. Thanks to @​ashughes for reporting this and to @​mhidaka and @​hiroaki404 for bringing it to my attention at a Japan Android testing event.

Workaround for Overlap Handling for SDK 35 Compose Screenshots

Problem

When updating to SDK 35 and using the default theme, the ActionBar is included in screenshots, leading to overlap when using createComposeRule(). This occurs because createComposeRule() uses the default theme by default. Thank you for letting me know about this, @​keyboardsurfer!

I have filed an issue for this: https://issuetracker.google.com/issues/383368165

Why this happens

SDK 35 enforces edge-to-edge display, which means it does not provide automatic padding for the ActionBar.

How Roborazzi currently workarounds this

Roborazzi now automatically hides the ActionBar when taking screenshots on SDK 35 and higher. This functions similarly to view.getActivity()?.actionBar?.hide(). However, this workaround may cause performance issues and should not be relied upon. Roborazzi outputs warning logs with alternative suggestions. Thank you to @​sergio-sastre for advising on this workaround!

If you need to include the ActionBar in screenshots, Roborazzi provides a flag, roborazzi.compose.actionbar.overlap.fix=false, that can be added to your gradle.properties file.

What should we do?

A permanent solution will likely require changes from Google. In the meantime, adding <application android:theme="@style/Theme.AppCompat.Light.NoActionBar" /> to the module's src/test/AndroidManifest.xml file changes the Activity's default theme and resolves the issue. Thank you to @​mattinger for finding this!

takahirom/roborazzi#598

Stabilized Output for Dump Screenshots

Thanks to @​siarhei-luskanau for contributing an improvement that reduces unnecessary diffs for the Roborazzi dump feature.

New Features

Add inspectionMode() for Compose Previews

Thanks to @​YusukeMoriJapan's contribution, inspectionMode() is now available in RoborazziComposeOptions. This is particularly useful when working with libraries that have specific preview implementations. This mode is off by default to maintain high fidelity.

Here's how to enable it:

captureRoboImage(
</tr></table> 

... (truncated)

Commits
  • 297a715 Merge pull request #610 from takahirom/takahirom/fix-name-of-inspectionMode/2...
  • b21d5d3 Fix name of inspectionMode
  • c9d0185 1.37.0
  • c904c1d Merge pull request #604 from takahirom/takahirom/add-workaround-for-overlap/2...
  • 7382573 Merge branch 'main' into takahirom/add-workaround-for-overlap/2024-12-12
  • f508092 Merge pull request #609 from takahirom/takahirom/revert-compileSdk-and-target...
  • 1f82d36 Revert compileSdk and targetSdk for library
  • 4f7ef54 Merge pull request #603 from takahirom/takahirom/add-default-theme-test/2024-...
  • 371cce6 Merge pull request #555 from takahirom/takahirom/add-alertdialog-test/2024-11-15
  • afe80c0 Fix to use actionBar.hide() to do workaround
  • Additional commits viewable in compare view

Updates io.github.takahirom.roborazzi:roborazzi-compose from 1.34.0 to 1.37.0

Release notes

Sourced from io.github.takahirom.roborazzi:roborazzi-compose's releases.

1.37.0

Bug Fixes and Workarounds

Compose AlertDialog Support

Support for capturing Alert Dialogs has been fixed, ensuring correct screenshot display. captureScreenRoboImage(), which merges all windows, is now used only when multiple windows are present. Thanks to @​ashughes for reporting this and to @​mhidaka and @​hiroaki404 for bringing it to my attention at a Japan Android testing event.

Workaround for Overlap Handling for SDK 35 Compose Screenshots

Problem

When updating to SDK 35 and using the default theme, the ActionBar is included in screenshots, leading to overlap when using createComposeRule(). This occurs because createComposeRule() uses the default theme by default. Thank you for letting me know about this, @​keyboardsurfer!

I have filed an issue for this: https://issuetracker.google.com/issues/383368165

Why this happens

SDK 35 enforces edge-to-edge display, which means it does not provide automatic padding for the ActionBar.

How Roborazzi currently workarounds this

Roborazzi now automatically hides the ActionBar when taking screenshots on SDK 35 and higher. This functions similarly to view.getActivity()?.actionBar?.hide(). However, this workaround may cause performance issues and should not be relied upon. Roborazzi outputs warning logs with alternative suggestions. Thank you to @​sergio-sastre for advising on this workaround!

If you need to include the ActionBar in screenshots, Roborazzi provides a flag, roborazzi.compose.actionbar.overlap.fix=false, that can be added to your gradle.properties file.

What should we do?

A permanent solution will likely require changes from Google. In the meantime, adding <application android:theme="@style/Theme.AppCompat.Light.NoActionBar" /> to the module's src/test/AndroidManifest.xml file changes the Activity's default theme and resolves the issue. Thank you to @​mattinger for finding this!

takahirom/roborazzi#598

Stabilized Output for Dump Screenshots

Thanks to @​siarhei-luskanau for contributing an improvement that reduces unnecessary diffs for the Roborazzi dump feature.

New Features

Add inspectionMode() for Compose Previews

Thanks to @​YusukeMoriJapan's contribution, inspectionMode() is now available in RoborazziComposeOptions. This is particularly useful when working with libraries that have specific preview implementations. This mode is off by default to maintain high fidelity.

Here's how to enable it:

captureRoboImage(
</tr></table> 

... (truncated)

Commits
  • 297a715 Merge pull request #610 from takahirom/takahirom/fix-name-of-inspectionMode/2...
  • b21d5d3 Fix name of inspectionMode
  • c9d0185 1.37.0
  • c904c1d Merge pull request #604 from takahirom/takahirom/add-workaround-for-overlap/2...
  • 7382573 Merge branch 'main' into takahirom/add-workaround-for-overlap/2024-12-12
  • f508092 Merge pull request #609 from takahirom/takahirom/revert-compileSdk-and-target...
  • 1f82d36 Revert compileSdk and targetSdk for library
  • 4f7ef54 Merge pull request #603 from takahirom/takahirom/add-default-theme-test/2024-...
  • 371cce6 Merge pull request #555 from takahirom/takahirom/add-alertdialog-test/2024-11-15
  • afe80c0 Fix to use actionBar.hide() to do workaround
  • Additional commits viewable in compare view

Updates io.github.takahirom.roborazzi:roborazzi-junit-rule from 1.34.0 to 1.37.0

Release notes

Sourced from io.github.takahirom.roborazzi:roborazzi-junit-rule's releases.

1.37.0

Bug Fixes and Workarounds

Compose AlertDialog Support

Support for capturing Alert Dialogs has been fixed, ensuring correct screenshot display. captureScreenRoboImage(), which merges all windows, is now used only when multiple windows are present. Thanks to @​ashughes for reporting this and to @​mhidaka and @​hiroaki404 for bringing it to my attention at a Japan Android testing event.

Workaround for Overlap Handling for SDK 35 Compose Screenshots

Problem

When updating to SDK 35 and using the default theme, the ActionBar is included in screenshots, leading to overlap when using createComposeRule(). This occurs because createComposeRule() uses the default theme by default. Thank you for letting me know about this, @​keyboardsurfer!

I have filed an issue for this: https://issuetracker.google.com/issues/383368165

Why this happens

SDK 35 enforces edge-to-edge display, which means it does not provide automatic padding for the ActionBar.

How Roborazzi currently workarounds this

Roborazzi now automatically hides the ActionBar when taking screenshots on SDK 35 and higher. This functions similarly to view.getActivity()?.actionBar?.hide(). However, this workaround may cause performance issues and should not be relied upon. Roborazzi outputs warning logs with alternative suggestions. Thank you to @​sergio-sastre for advising on this workaround!

If you need to include the ActionBar in screenshots, Roborazzi provides a flag, roborazzi.compose.actionbar.overlap.fix=false, that can be added to your gradle.properties file.

What should we do?

A permanent solution will likely require changes from Google. In the meantime, adding <application android:theme="@style/Theme.AppCompat.Light.NoActionBar" /> to the module's src/test/AndroidManifest.xml file changes the Activity's default theme and resolves the issue. Thank you to @​mattinger for finding this!

takahirom/roborazzi#598

Stabilized Output for Dump Screenshots

Thanks to @​siarhei-luskanau for contributing an improvement that reduces unnecessary diffs for the Roborazzi dump feature.

New Features

Add inspectionMode() for Compose Previews

Thanks to @​YusukeMoriJapan's contribution, inspectionMode() is now available in RoborazziComposeOptions. This is particularly useful when working with libraries that have specific preview implementations. This mode is off by default to maintain high fidelity.

Here's how to enable it:

captureRoboImage(
</tr></table> 

... (truncated)

Commits
  • 297a715 Merge pull request #610 from takahirom/takahirom/fix-name-of-inspectionMode/2...
  • b21d5d3 Fix name of inspectionMode
  • c9d0185 1.37.0
  • c904c1d Merge pull request #604 from takahirom/takahirom/add-workaround-for-overlap/2...
  • 7382573 Merge branch 'main' into takahirom/add-workaround-for-overlap/2024-12-12
  • f508092 Merge pull request #609 from takahirom/takahirom/revert-compileSdk-and-target...
  • 1f82d36 Revert compileSdk and targetSdk for library
  • 4f7ef54 Merge pull request #603 from takahirom/takahirom/add-default-theme-test/2024-...
  • 371cce6 Merge pull request #555 from takahirom/takahirom/add-alertdialog-test/2024-11-15
  • afe80c0 Fix to use actionBar.hide() to do workaround
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps `roborazzi` from 1.34.0 to 1.37.0.

Updates `io.github.takahirom.roborazzi:roborazzi-gradle-plugin` from 1.34.0 to 1.37.0
- [Release notes](https://github.com/takahirom/roborazzi/releases)
- [Commits](takahirom/roborazzi@1.34.0...1.37.0)

Updates `io.github.takahirom.roborazzi:roborazzi` from 1.34.0 to 1.37.0
- [Release notes](https://github.com/takahirom/roborazzi/releases)
- [Commits](takahirom/roborazzi@1.34.0...1.37.0)

Updates `io.github.takahirom.roborazzi:roborazzi-compose` from 1.34.0 to 1.37.0
- [Release notes](https://github.com/takahirom/roborazzi/releases)
- [Commits](takahirom/roborazzi@1.34.0...1.37.0)

Updates `io.github.takahirom.roborazzi:roborazzi-junit-rule` from 1.34.0 to 1.37.0
- [Release notes](https://github.com/takahirom/roborazzi/releases)
- [Commits](takahirom/roborazzi@1.34.0...1.37.0)

---
updated-dependencies:
- dependency-name: io.github.takahirom.roborazzi:roborazzi-gradle-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: io.github.takahirom.roborazzi:roborazzi
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: io.github.takahirom.roborazzi:roborazzi-compose
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: io.github.takahirom.roborazzi:roborazzi-junit-rule
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants