-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: sync develop and deprecation related changes #6635
Conversation
Signed-off-by: Prashant Shahi <[email protected]>
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Let's squash it and mention in the description that this was a migration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to e21b9a5 in 2 minutes and 0 seconds
More details
- Looked at
536
lines of code in19
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. deploy/README.md:61
- Draft comment:
The deploy/README.md file still references the 'develop' branch. Update this to reflect the new branch strategy, using 'main' instead of 'develop'. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. frontend/src/api/messagingQueues/getTopicThroughputOverview.ts:1
- Draft comment:
Avoid using thecomponent/index.tsx
file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This issue is present in this file and other similar files. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_v2ZdnkZo21nN9EyR
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
We can do that - But it will cause all new PRs merged in |
Created another PR with the latest changes as the base. |
Summary
Important
Sync changes from
develop
tomain
and update CI/CD workflows and documentation to usemain
branch.develop
tomain
.develop
branch usage in favor ofmain
.develop
tomain
in.github/workflows/build.yaml
,docs.yml
,jest-coverage-changes.yml
,push.yaml
,sonar.yml
,staging-deployment.yaml
, andtesting-deployment.yaml
.develop
tomain
ine2e-k3s.yaml
,CONTRIBUTING.md
,deploy/README.md
,sample-apps/hotrod/README.md
,hotrod-delete.sh
, andhotrod-install.sh
.getTopicThroughputOverview.ts
path fromMQDetails/MQTables
toapi/messagingQueues
.develop
branch commit restriction in.husky/commit-msg
.This description was created by for e21b9a5. It will automatically update as commits are pushed.