Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync develop and deprecation related changes #6635

Closed
wants to merge 7 commits into from

Conversation

prashant-shahi
Copy link
Member

@prashant-shahi prashant-shahi commented Dec 13, 2024

Summary

  • sync latest changes from develop to main
  • deprecate usage of develop branch - use main instead for CI and links in README and sample-apps

Important

Sync changes from develop to main and update CI/CD workflows and documentation to use main branch.

  • Branch Sync:
    • Sync changes from develop to main.
    • Deprecate develop branch usage in favor of main.
  • CI/CD Workflows:
    • Update branch references from develop to main in .github/workflows/build.yaml, docs.yml, jest-coverage-changes.yml, push.yaml, sonar.yml, staging-deployment.yaml, and testing-deployment.yaml.
    • Change HotROD sample app URLs from develop to main in e2e-k3s.yaml, CONTRIBUTING.md, deploy/README.md, sample-apps/hotrod/README.md, hotrod-delete.sh, and hotrod-install.sh.
  • Frontend:
    • Rename getTopicThroughputOverview.ts path from MQDetails/MQTables to api/messagingQueues.
    • Remove develop branch commit restriction in .husky/commit-msg.

This description was created by Ellipsis for e21b9a5. It will automatically update as commits are pushed.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the chore label Dec 13, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@grandwizard28
Copy link
Collaborator

Let's squash it and mention in the description that this was a migration

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e21b9a5 in 2 minutes and 0 seconds

More details
  • Looked at 536 lines of code in 19 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. deploy/README.md:61
  • Draft comment:
    The deploy/README.md file still references the 'develop' branch. Update this to reflect the new branch strategy, using 'main' instead of 'develop'.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. frontend/src/api/messagingQueues/getTopicThroughputOverview.ts:1
  • Draft comment:
    Avoid using the component/index.tsx file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This issue is present in this file and other similar files.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_v2ZdnkZo21nN9EyR


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@prashant-shahi prashant-shahi changed the title chore: sync develop chore: sync develop and deprecation related changes Dec 13, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@prashant-shahi
Copy link
Member Author

Let's squash it and mention in the description that this was a migration

We can do that - But it will cause all new PRs merged in develop to be shown as a single commit and task of manually including them in release notes.

@prashant-shahi
Copy link
Member Author

Created another PR with the latest changes as the base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants