feat: implement nodes list table in infra monitoring #6615
+688
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
amlannandy
commented
Dec 11, 2024
| @@ -14,6 +14,13 @@ import { | |||
| } from 'components/QuickFilters/QuickFilters'; | |||
| import { DataTypes } from 'types/api/queryBuilder/queryAutocompleteResponse'; | |||
|
|
|||
| export interface IEntityColumn { | |||
There was a problem hiding this comment.
Using this instead of IPodColumn. As we're reusing it, thought it should have a more generic name.
We can remove IPodColumn in the end. I didn't rename it now to avoid conflicts.
amlannandy
commented
Dec 11, 2024
| @@ -127,4 +128,11 @@ function K8sHeader({ | |||
| ); | |||
| } | |||
|
|
|||
| K8sHeader.defaultProps = { | |||
There was a problem hiding this comment.
Made these fields optional for list views where there is no metadata to show
amlannandy
force-pushed
the
feat/infra-monitoring-k8s-nodes
branch
2 times, most recently
from
ea32f5e to
0bbd4d0
Compare
amlannandy
force-pushed
the
feat/infra-monitoring-k8s-nodes
branch
from
f8b95d1 to
efd5c2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement the nodes list table in Infra Monitoring
Related Issues / PR's
N/A
Screenshots
N/A
Affected Areas and Manually Tested Areas
Infra Monitoring section