Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix-autocomplete-time-selection #5880

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix-autocomplete-time-selection #5880

wants to merge 4 commits into from

Conversation

Rahul-2006
Copy link

Fix: Disable autocomplete on time selection field to prevent password manager interference

@Rahul-2006
fix-autocomplete-time-selection
15b7752 
Fix: Disable autocomplete on time selection field to prevent password manager interference
@Rahul-2006 Rahul-2006 requested a review from YounixM as a code owner September 6, 2024 14:13
@welcome Welcome
Copy link

welcome bot commented Sep 6, 2024

Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Rahul-2006
Copy link
Author

I have fixed the autocomplete time selection . please review it and let me know if there are any changes required

rahulkeswani101
rahulkeswani101 reviewed Sep 6, 2024
View reviewed changes
Copy link
Contributor

@rahulkeswani101 rahulkeswani101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rahul-2006 Can you please remove the changes for package-lock.json?

@Rahul-2006
Copy link
Author

I removed the changes in package-lock.json
please check.

@Rahul-2006
Copy link
Author

Can anyone please check my pull request and if it is okay merge it or let me know if there are any changes

@rahulkeswani101
Copy link
Contributor

@Rahul-2006 Can you please add screenshots or video so we can see what has been fixed?

@rahulkeswani101
Copy link
Contributor

@Rahul-2006 can you check whether the attribute that you have added is correct?

@Rahul-2006
Copy link
Author

Yes I checked it and it works fine
If you feel this isn't working the way you wanted you can take some others help, since I can't take it to further extents.
Thank you

@prashant-shahi prashant-shahi changed the base branch from develop to main December 19, 2024 12:14
@prashant-shahi prashant-shahi requested a review from a team December 19, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulkeswani101 rahulkeswani101 rahulkeswani101 left review comments

@YounixM YounixM Awaiting requested review from YounixM YounixM is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rahul-2006 @CLAassistant @rahulkeswani101