This repository has been archived by the owner on Mar 7, 2018. It is now read-only.
update multiple widgets in one request #490
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| widget_id = widget.delete("id") | ||
| send_event(widget_id, widget) | ||
| end | ||
| 204 # response without entity body |
There was a problem hiding this comment.
if you just return status 204 the comment will not be necessary anymore.
There was a problem hiding this comment.
This is the existing pattern in the file -- they should all be modified in this way if desired.
My preference is to leave it as a comment, so that you don't have to look up 204. IMHO it is not a very common HTTP response code.
|
This PR adds new functionality with associated tests -- no breaking changes. 👍 for merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.