This repository has been archived by the owner on Mar 7, 2018. It is now read-only.
Adding status to all widgets #402
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for dynamic alert messages.
|
Makes sense to me, this would be a non-breaking change as triggering it would require events to be sent with a status field. 👍 for merging. |
|
As I mentioned in #255 -- perhaps this should be moved up the chain to Dashing.Widget so that all widgets support data-status. |
cbrentharris
changed the title
|
Moved up to Dashing.Widget |
gottfrois
added a commit
to gottfrois/dashing-rails
that referenced
this pull request
Jan 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for dynamic alert messages. Since it is included in number.coffee, thought it would make sense here as well.