Cherry-pick 29 ladybird PRs, and update GN build

Ladybird/Qt/Tab.cpp

@@ -61,11 +61,15 @@ Tab::Tab(BrowserWindow* window, WebContentOptions const& web_content_options, St
     m_toolbar = new QToolBar(this);
     m_location_edit = new LocationEdit(this);
 
-    m_hover_label = new QLabel(this);
+    m_hover_label = new HyperlinkLabel(this);
     m_hover_label->hide();
     m_hover_label->setFrameShape(QFrame::Shape::Box);
     m_hover_label->setAutoFillBackground(true);
 
+    QObject::connect(m_hover_label, &HyperlinkLabel::mouse_entered, [this] {
+        update_hover_label();
+    });
+
     auto* focus_location_editor_action = new QAction("Edit Location", this);
     focus_location_editor_action->setShortcut(QKeySequence("Ctrl+L"));
     addAction(focus_location_editor_action);
@@ -862,12 +866,18 @@ void Tab::resizeEvent(QResizeEvent* event)
 
 void Tab::update_hover_label()
 {
+    m_hover_label->setText(QFontMetrics(m_hover_label->font()).elidedText(m_hover_label->text(), Qt::ElideRight, width() / 2 - 10));
     m_hover_label->resize(QFontMetrics(m_hover_label->font()).boundingRect(m_hover_label->text()).adjusted(-4, -2, 4, 2).size());
-    auto hover_label_height = height() - m_hover_label->height() - 8;
+
+    auto hover_label_height = height() - m_hover_label->height();
     if (m_find_in_page->isVisible())
-        hover_label_height -= m_find_in_page->height() - 4;
+        hover_label_height -= m_find_in_page->height();
+
+    if (m_hover_label->underMouse() && m_hover_label->x() == 0)
+        m_hover_label->move(width() / 2 + (width() / 2 - m_hover_label->width()), hover_label_height);
+    else
+        m_hover_label->move(0, hover_label_height);
 
-    m_hover_label->move(6, hover_label_height);
     m_hover_label->raise();
 }
 

Ladybird/Qt/Tab.h

@@ -25,6 +25,25 @@ namespace Ladybird {
 class BrowserWindow;
 class InspectorWidget;
 
+class HyperlinkLabel final : public QLabel {
+    Q_OBJECT
+
+public:
+    explicit HyperlinkLabel(QWidget* parent = nullptr)
+        : QLabel(parent)
+    {
+        setMouseTracking(true);
+    }
+
+    virtual void enterEvent(QEnterEvent* event) override
+    {
+        emit mouse_entered(event);
+    }
+
+signals:
+    void mouse_entered(QEnterEvent*);
+};
+
 class Tab final : public QWidget {
     Q_OBJECT
 
@@ -114,7 +133,7 @@ public slots:
     FindInPageWidget* m_find_in_page { nullptr };
     BrowserWindow* m_window { nullptr };
     QString m_title;
-    QLabel* m_hover_label { nullptr };
+    HyperlinkLabel* m_hover_label { nullptr };
     QIcon m_favicon;
 
     QMenu* m_context_menu { nullptr };

Ladybird/Qt/WebContentView.cpp

@@ -423,6 +423,7 @@ void WebContentView::mouseMoveEvent(QMouseEvent* event)
     }
 
     enqueue_native_event(Web::MouseEvent::Type::MouseMove, *event);
+    QWidget::mouseMoveEvent(event);
 }
 
 void WebContentView::mousePressEvent(QMouseEvent* event)

Meta/gn/secondary/Userland/Libraries/LibGfx/BUILD.gn

@@ -57,6 +57,7 @@ shared_library("LibGfx") {
     "Font/WOFF/Font.cpp",
     "Font/WOFF2/Font.cpp",
     "FontCascadeList.cpp",
+    "GlassWindowTheme.cpp",
     "GradientPainting.cpp",
     "ICC/BinaryWriter.cpp",
     "ICC/Enums.cpp",
@@ -108,6 +109,7 @@ shared_library("LibGfx") {
     "Palette.cpp",
     "Path.cpp",
     "PathClipper.cpp",
+    "PlasticWindowTheme.cpp",
     "Point.cpp",
     "Rect.cpp",
     "ShareableBitmap.cpp",
@@ -118,7 +120,6 @@ shared_library("LibGfx") {
     "TextLayout.cpp",
     "Triangle.cpp",
     "VectorGraphic.cpp",
-    "WindowTheme.cpp",
   ]
 
   sources += get_target_outputs(":generate_tiff_sources")

Tests/LibCrypto/TestBigInteger.cpp

@@ -664,6 +664,17 @@ TEST_CASE(test_negative_zero_is_not_allowed)
     EXPECT(!zero.is_negative());
 }
 
+TEST_CASE(test_i32_limits)
+{
+    Crypto::SignedBigInteger min { AK::NumericLimits<i32>::min() };
+    EXPECT(min.is_negative());
+    EXPECT(min.unsigned_value().to_u64() == static_cast<u32>(AK::NumericLimits<i32>::max()) + 1);
+
+    Crypto::SignedBigInteger max { AK::NumericLimits<i32>::max() };
+    EXPECT(!max.is_negative());
+    EXPECT(max.unsigned_value().to_u64() == AK::NumericLimits<i32>::max());
+}
+
 TEST_CASE(double_comparisons)
 {
 #define EXPECT_LESS_THAN(bigint, double_value) EXPECT_EQ(bigint.compare_to_double(double_value), Crypto::UnsignedBigInteger::CompareResult::DoubleGreaterThanBigInt)

Tests/LibWeb/Layout/expected/svg/standalone-h.txt

@@ -0,0 +1,18 @@
+Viewport <#document> at (0,0) content-size 800x600 [BFC] children: not-inline
+  SVGSVGBox <svg> at (0,0) content-size 128x600 [SVG] children: inline
+    TextNode <#text>
+    TextNode <#text>
+    SVGGeometryBox <rect> at (0,172) content-size 128x256 children: not-inline
+    TextNode <#text>
+    SVGGraphicsBox <g> at (0,172) content-size 128x256 children: inline
+      TextNode <#text>
+      SVGGeometryBox <path> at (0,172) content-size 128x256 children: not-inline
+      TextNode <#text>
+    TextNode <#text>
+
+ViewportPaintable (Viewport<#document>) [0,0 800x600]
+  SVGSVGPaintable (SVGSVGBox<svg>) [0,0 128x600]
+    SVGPathPaintable (SVGGeometryBox<rect>) [0,172 128x256]
+    SVGGraphicsPaintable (SVGGraphicsBox<g>) [0,172 128x256]
+      SVGPathPaintable (SVGGeometryBox<path>) [0,172 128x256]
+

Tests/LibWeb/Layout/expected/svg/standalone-vb-h.txt

@@ -0,0 +1,18 @@
+Viewport <#document> at (0,0) content-size 800x600 [BFC] children: not-inline
+  SVGSVGBox <svg> at (0,0) content-size 128x600 [SVG] children: inline
+    TextNode <#text>
+    TextNode <#text>
+    SVGGeometryBox <rect> at (0,0) content-size 32x64 children: not-inline
+    TextNode <#text>
+    SVGGraphicsBox <g> at (0,0) content-size 32x64 children: inline
+      TextNode <#text>
+      SVGGeometryBox <path> at (0,0) content-size 32x64 children: not-inline
+      TextNode <#text>
+    TextNode <#text>
+
+ViewportPaintable (Viewport<#document>) [0,0 800x600]
+  SVGSVGPaintable (SVGSVGBox<svg>) [0,0 128x600]
+    SVGPathPaintable (SVGGeometryBox<rect>) [0,0 32x64]
+    SVGGraphicsPaintable (SVGGraphicsBox<g>) [0,0 32x64]
+      SVGPathPaintable (SVGGeometryBox<path>) [0,0 32x64]
+

Tests/LibWeb/Layout/expected/svg/standalone-vb-w.txt

@@ -0,0 +1,18 @@
+Viewport <#document> at (0,0) content-size 800x600 [BFC] children: not-inline
+  SVGSVGBox <svg> at (0,0) content-size 800x256 [SVG] children: inline
+    TextNode <#text>
+    TextNode <#text>
+    SVGGeometryBox <rect> at (0,0) content-size 32x64 children: not-inline
+    TextNode <#text>
+    SVGGraphicsBox <g> at (0,0) content-size 32x64 children: inline
+      TextNode <#text>
+      SVGGeometryBox <path> at (0,0) content-size 32x64 children: not-inline
+      TextNode <#text>
+    TextNode <#text>
+
+ViewportPaintable (Viewport<#document>) [0,0 800x600]
+  SVGSVGPaintable (SVGSVGBox<svg>) [0,0 800x256]
+    SVGPathPaintable (SVGGeometryBox<rect>) [0,0 32x64]
+    SVGGraphicsPaintable (SVGGraphicsBox<g>) [0,0 32x64]
+      SVGPathPaintable (SVGGeometryBox<path>) [0,0 32x64]
+

Tests/LibWeb/Layout/expected/svg/standalone-vb-wh.txt

@@ -0,0 +1,18 @@
+Viewport <#document> at (0,0) content-size 800x600 [BFC] children: not-inline
+  SVGSVGBox <svg> at (0,0) content-size 800x600 [SVG] children: inline
+    TextNode <#text>
+    TextNode <#text>
+    SVGGeometryBox <rect> at (0,0) content-size 32x64 children: not-inline
+    TextNode <#text>
+    SVGGraphicsBox <g> at (0,0) content-size 32x64 children: inline
+      TextNode <#text>
+      SVGGeometryBox <path> at (0,0) content-size 32x64 children: not-inline
+      TextNode <#text>
+    TextNode <#text>
+
+ViewportPaintable (Viewport<#document>) [0,0 800x600]
+  SVGSVGPaintable (SVGSVGBox<svg>) [0,0 800x600]
+    SVGPathPaintable (SVGGeometryBox<rect>) [0,0 32x64]
+    SVGGraphicsPaintable (SVGGraphicsBox<g>) [0,0 32x64]
+      SVGPathPaintable (SVGGeometryBox<path>) [0,0 32x64]
+

Tests/LibWeb/Layout/expected/svg/standalone-vb.txt

@@ -0,0 +1,18 @@
+Viewport <#document> at (0,0) content-size 800x600 [BFC] children: not-inline
+  SVGSVGBox <svg> at (0,0) content-size 128x256 [SVG] children: inline
+    TextNode <#text>
+    TextNode <#text>
+    SVGGeometryBox <rect> at (0,0) content-size 32x64 children: not-inline
+    TextNode <#text>
+    SVGGraphicsBox <g> at (0,0) content-size 32x64 children: inline
+      TextNode <#text>
+      SVGGeometryBox <path> at (0,0) content-size 32x64 children: not-inline
+      TextNode <#text>
+    TextNode <#text>
+
+ViewportPaintable (Viewport<#document>) [0,0 800x600]
+  SVGSVGPaintable (SVGSVGBox<svg>) [0,0 128x256]
+    SVGPathPaintable (SVGGeometryBox<rect>) [0,0 32x64]
+    SVGGraphicsPaintable (SVGGraphicsBox<g>) [0,0 32x64]
+      SVGPathPaintable (SVGGeometryBox<path>) [0,0 32x64]
+

Tests/LibWeb/Layout/expected/svg/standalone-w.txt

@@ -0,0 +1,18 @@
+Viewport <#document> at (0,0) content-size 800x600 [BFC] children: not-inline
+  SVGSVGBox <svg> at (0,0) content-size 800x256 [SVG] children: inline
+    TextNode <#text>
+    TextNode <#text>
+    SVGGeometryBox <rect> at (336,0) content-size 128x256 children: not-inline
+    TextNode <#text>
+    SVGGraphicsBox <g> at (336,0) content-size 128x256 children: inline
+      TextNode <#text>
+      SVGGeometryBox <path> at (336,0) content-size 128x256 children: not-inline
+      TextNode <#text>
+    TextNode <#text>
+
+ViewportPaintable (Viewport<#document>) [0,0 800x600]
+  SVGSVGPaintable (SVGSVGBox<svg>) [0,0 800x256]
+    SVGPathPaintable (SVGGeometryBox<rect>) [336,0 128x256]
+    SVGGraphicsPaintable (SVGGraphicsBox<g>) [336,0 128x256]
+      SVGPathPaintable (SVGGeometryBox<path>) [336,0 128x256]
+

Tests/LibWeb/Layout/expected/svg/standalone-wh.txt

@@ -0,0 +1,18 @@
+Viewport <#document> at (0,0) content-size 800x600 [BFC] children: not-inline
+  SVGSVGBox <svg> at (0,0) content-size 800x600 [SVG] children: inline
+    TextNode <#text>
+    TextNode <#text>
+    SVGGeometryBox <rect> at (250,0) content-size 300x600 children: not-inline
+    TextNode <#text>
+    SVGGraphicsBox <g> at (250,0) content-size 300x600 children: inline
+      TextNode <#text>
+      SVGGeometryBox <path> at (250,0) content-size 300x600 children: not-inline
+      TextNode <#text>
+    TextNode <#text>
+
+ViewportPaintable (Viewport<#document>) [0,0 800x600]
+  SVGSVGPaintable (SVGSVGBox<svg>) [0,0 800x600]
+    SVGPathPaintable (SVGGeometryBox<rect>) [250,0 300x600]
+    SVGGraphicsPaintable (SVGGraphicsBox<g>) [250,0 300x600]
+      SVGPathPaintable (SVGGeometryBox<path>) [250,0 300x600]
+

Tests/LibWeb/Layout/expected/svg/standalone.txt

@@ -0,0 +1,17 @@
+Viewport <#document> at (0,0) content-size 800x600 [BFC] children: not-inline
+  SVGSVGBox <svg> at (0,0) content-size 128x256 [SVG] children: inline
+    TextNode <#text>
+    TextNode <#text>
+    SVGGeometryBox <rect> at (0,0) content-size 128x256 children: not-inline
+    TextNode <#text>
+    SVGGraphicsBox <g> at (0,0) content-size 128x256 children: inline
+      TextNode <#text>
+      SVGGeometryBox <path> at (0,0) content-size 128x256 children: not-inline
+      TextNode <#text>
+    TextNode <#text>
+
+ViewportPaintable (Viewport<#document>) [0,0 800x600]
+  SVGSVGPaintable (SVGSVGBox<svg>) [0,0 128x256]
+    SVGPathPaintable (SVGGeometryBox<rect>) [0,0 128x256]
+    SVGGraphicsPaintable (SVGGraphicsBox<g>) [0,0 128x256]
+      SVGPathPaintable (SVGGeometryBox<path>) [0,0 128x256]

Tests/LibWeb/Ref/css-keyframe-invalid-transform-should-not-render.html

@@ -5,7 +5,7 @@
         width: 100px;
         height: 100px;
         background-color: blue;
-        animation: anim 1s;
+        animation: anim 100s;
     }
     @keyframes anim {
         from {
@@ -18,5 +18,5 @@
 </style>
 <div id="foo"></div>
 <script>
-    document.getElementById("foo").getAnimations()[0].currentTime = 500;
+    document.getElementById("foo").getAnimations()[0].currentTime = 50_000; // 50 seconds
 </script>

Tests/LibWeb/Ref/css-open-closed-selectors.html

@@ -4,9 +4,6 @@
 :open {
     color: green;
 }
-:closed {
-    color: red;
-}
 </style>
 <details open>
     <summary>Hi</summary>

Tests/LibWeb/Ref/reference/css-open-closed-selectors-ref.html

@@ -3,15 +3,12 @@
     .open {
         color: green;
     }
-    .closed {
-        color: red;
-    }
 </style>
 <details open class="open">
     <summary>Hi</summary>
     Well hello friends!
 </details>
-<details class="closed">
+<details>
     <summary>Hi</summary>
     Well hello friends!
 </details>

Tests/LibWeb/Text/expected/CloseWatcher-abort-requestClose.txt

@@ -0,0 +1,2 @@
+false
+false

Tests/LibWeb/Text/expected/CloseWatcher-already-aborted.txt

@@ -0,0 +1,2 @@
+false
+false

Tests/LibWeb/Text/expected/CloseWatcher-fire-once.txt

@@ -0,0 +1,2 @@
+1
+1

Tests/LibWeb/Text/expected/Crypto/Crypto-getRandomValues-respects-subarrays.txt

@@ -0,0 +1,2 @@
+Is first 2 bytes still 0x41? true
+Is last 6 bytes still 0x41? true