Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected]: Add autoupdate hash url #6351

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

o-l-a-v
Copy link
Contributor

@o-l-a-v o-l-a-v commented Dec 1, 2024

Adds autoupdate hash URL so Scoop does not have to download the artifact to calculate checksum.

Copy link
Contributor

github-actions bot commented Dec 1, 2024

Your changes do not pass checks.

deno

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Dec 1, 2024

Never mind, Deno uses a non-standard format for the sha256sum file.


Algorithm : SHA256
Hash      : E107BDD19CD38314C6EC934B7345E3139739C3A1106F951F6F70F8FB04F293E8
Path      : C:\a\deno\deno\target\release\deno-x86_64-pc-windows-msvc.zip


Edit: Learned I can use regex to find it. 😊

@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Dec 12, 2024

/validate

@chawyehsu
Copy link
Member

/verify

Copy link
Contributor

Your changes do not pass checks.

deno

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Dec 17, 2024

From the workflow logs I don't see what's wrong with Checkver. 🤔

It works when testing locally.

PS > & ('{0}\scoop\apps\scoop\current\bin\checkver.ps1' -f $env:USERPROFILE) -Force -App (
    '{0}\IT\Code\PowerShell\CLI\Scoop\Scoop-ManifestAuthoring\bucket\deno.json' -f $env:OneDriveConsumer
)

deno: 2.1.4 (scoop version is 2.1.4)
Forcing autoupdate!
Autoupdating deno
Searching hash for deno-x86_64-pc-windows-msvc.zip in https://github.com/denoland/deno/releases/download/v2.1.4/deno-x86_64-pc-windows-msvc.zip.sha256sum
Could not find hash in https://github.com/denoland/deno/releases/download/v2.1.4/deno-x86_64-pc-windows-msvc.zip.sha256sum
Downloading deno-x86_64-pc-windows-msvc.zip to compute hashes!
Loading deno-x86_64-pc-windows-msvc.zip from cache
Computed hash: d85abec3fc5533c20f1369b9c2fbb5f49348d1f69994779c09f56383bd46aa10
Writing updated deno manifest

PS >

@niheaven
Copy link
Member

/verify

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

deno

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@niheaven niheaven merged commit ac127f4 into ScoopInstaller:master Dec 18, 2024
2 checks passed
@o-l-a-v o-l-a-v deleted the deno-add-autoupdate-hash branch December 18, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants