Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[email protected]: Add uninstall purge logic for proper nuke on uninstall --purge + use GitHub releases for faster download #6007

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

[email protected]: Add uninstall purge logic for proper nuke on uninstall --purge + use GitHub releases for faster download #6007

wants to merge 16 commits into from

Conversation

o-l-a-v
Copy link
Contributor

@o-l-a-v o-l-a-v commented Jul 9, 2024 •
edited
Loading

scoop uninstall azure-cli and scoop uninstall --purge azure-cli currently leaves a lot behind.

This PR does the following:

  1. Adds pre_uninstall to clear account cache using az account clear, and post_uninstall to remove known files and directories, if --purge was specified.
  2. Use GitHub releases for downloading the install file, as it's a lot faster than using Azure Storage Account blob storage, which is currently used.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

All changes look good.

Wait for review from human collaborators.

azure-cli

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@o-l-a-v o-l-a-v changed the title azure-cli - Add uninstall purge logic for proper nuke on uninstall --purge azure-cli: Add uninstall purge logic for proper nuke on uninstall --purge Aug 3, 2024
@o-l-a-v o-l-a-v changed the title azure-cli: Add uninstall purge logic for proper nuke on uninstall --purge azure-cli: Add uninstall purge logic for proper nuke on uninstall --purge + use GitHub releases for faster download Aug 7, 2024
@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Aug 7, 2024

Now also uses GitHub releases as URL for much faster download, available since v2.63.0 ref:

@stevehipwell
Copy link
Contributor

/verify

@stevehipwell stevehipwell requested a review from HUMORCE August 19, 2024 09:05
@github-actions GitHub Actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

azure-cli

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Sep 3, 2024

Fixed merge conflict.

@o-l-a-v o-l-a-v changed the title azure-cli: Add uninstall purge logic for proper nuke on uninstall --purge + use GitHub releases for faster download [email protected]: Add uninstall purge logic for proper nuke on uninstall --purge + use GitHub releases for faster download Oct 9, 2024
@o-l-a-v o-l-a-v changed the title [email protected]: Add uninstall purge logic for proper nuke on uninstall --purge + use GitHub releases for faster download [email protected]: Add uninstall purge logic for proper nuke on uninstall --purge + use GitHub releases for faster download Nov 11, 2024
@o-l-a-v o-l-a-v changed the title [email protected]: Add uninstall purge logic for proper nuke on uninstall --purge + use GitHub releases for faster download [email protected]: Add uninstall purge logic for proper nuke on uninstall --purge + use GitHub releases for faster download Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HUMORCE HUMORCE Awaiting requested review from HUMORCE

Assignees
No one assigned
Labels
review-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@o-l-a-v @stevehipwell