Curve element wrapper #1723
Open
Curve element wrapper #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heinezen
added
improvement
heinezen
requested changes
Dec 5, 2024
libopenage/curve/element_wrapper.h
Outdated
Comment on lines
1
to
5
| #pragma once | ||
| #include "time/time.h" |
There was a problem hiding this comment.
pragmas and includes should be separated by a space.
libopenage/curve/element_wrapper.h
Outdated
| } | ||
| }; | ||
|
|
||
| } |
libopenage/curve/element_wrapper.h
Outdated
Comment on lines
7
to
38
| struct element_wrapper { | ||
| // Insertion time of the element | ||
| time::time_t _alive; | ||
| // Erase time of the element | ||
| // TODO: this has to be mutable because erase() will complain otherwise | ||
| mutable time::time_t _dead; | ||
| // Element value | ||
| T value; | ||
|
|
||
| element_wrapper(const time::time_t &time, const T &value) : | ||
| _alive{time}, | ||
| _dead{time::TIME_MAX}, | ||
| value{value} {} | ||
|
|
||
| element_wrapper(const T &value, const time::time_t &alive, const time::time_t &dead) : | ||
| _alive{alive}, | ||
| _dead{dead}, | ||
| value{value} {} | ||
|
|
||
| const time::time_t &alive() const { | ||
| return _alive; | ||
| } | ||
|
|
||
| const time::time_t &dead() const { | ||
| return _dead; | ||
| } | ||
|
|
||
| // TODO: this has to be const because erase() will complain otherwise | ||
| void set_dead(const time::time_t &time) const { | ||
| _dead = time; | ||
| } | ||
| }; |
There was a problem hiding this comment.
Now that this struct moved to a separate file, we should document all its functions and constructors.
jere8184
force-pushed
the
curve_element_wrapper
branch
3 times, most recently
from
e890cf1 to
615441e
Compare
jere8184
force-pushed
the
curve_element_wrapper
branch
from
615441e to
b306c76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.