Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and Test Clang-tidy #1710

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Add and Test Clang-tidy #1710

wants to merge 12 commits into from

Conversation

haytham918
Copy link

@haytham918 haytham918 commented Nov 18, 2024 •
edited
Loading

Addressing the issue in #1060. Added clang-tidy check on files inside "libopenage" directory, focusing on "clang-analyzer", "bugprone", "concurrency", and "performance" issues. @heinezen

@haytham918
Copy link
Author

I think make checkall doesn't work for your workflow because it didn't detect installed clang-tidy

@heinezen heinezen added area: buildsystem Related to our cmake/python buildsystem lang: c++ Done in C++ code code quality Does not alter behavior, but beauty of our code labels Nov 18, 2024
@heinezen heinezen linked an issue Nov 18, 2024 that may be closed by this pull request
Add clang-tidy to buildsystem checks #1060
Open
@heinezen
Copy link
Member

@TheJJ kevin needs clang-tidy to be installed

@heinezen
Copy link
Member

@haytham918 You should add clang-tidy as a sanity check dependency in https://github.com/SFTtech/openage/blob/master/doc/building.md#dependencies

@haytham918
Copy link
Author

@heinezen Thank you for the notice. I have updated it accordingly.

TheJJ
TheJJ reviewed Nov 19, 2024
View reviewed changes
doc/building.md Outdated Show resolved Hide resolved
@heinezen heinezen added the kevin-rebuild-pl0x instruct kevin to rebuild this pull request label Nov 20, 2024
@SFTbot SFTbot removed the kevin-rebuild-pl0x instruct kevin to rebuild this pull request label Nov 20, 2024
@haytham918 haytham918 requested a review from TheJJ November 24, 2024 08:02
@heinezen
Copy link
Member

heinezen commented Dec 5, 2024

@TheJJ Did you add clang-tidy already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJJ TheJJ Awaiting requested review from TheJJ

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: buildsystem Related to our cmake/python buildsystem code quality Does not alter behavior, but beauty of our code lang: c++ Done in C++ code
Projects
openage code quality
Status: Review in progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add clang-tidy to buildsystem checks
4 participants
@haytham918 @heinezen @TheJJ @SFTbot