Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error caused by restore on running tests + build solution before run, instead of just restore #640

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

Larocceau
Copy link
Contributor

  • Remove dotnet restore action before running the watcher
  • instead of building just the shared path, build the full solution
  • Use no-restore when running server tests
  • restore full solution before running any tests

addresses what is left of #626 after partial fix in #634

…d the full solution before running test targets
@@ -78,6 +74,10 @@ Target.create "Format" (fun _ -> run dotnet [ "fantomas"; "." ] ".")
open Fake.Core.TargetOperators

let dependencies = [
"Build" ==> "RunTestsHeadless"
"Build" ==> "WatchRunTests"
"Build" ==> "Run"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you merge this with the Run pipeline below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let dependencies = [
    "Clean" ==> "RestoreClientDependencies" ==> "Bundle" ==> "Azure"
    "Clean" ==> "RestoreClientDependencies" ==> "Build" ==> "Run"

    "RestoreClientDependencies" ==> "Build" ==> "RunTestsHeadless"
    "RestoreClientDependencies" ==> "Build" ==> "WatchRunTests"
]

Like so?

@isaacabraham
Copy link
Member

Looks good to me overall :-)

@Larocceau Larocceau merged commit 259b130 into master Nov 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants