Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore as a standalone operation and remove from watch #634

Merged
merged 6 commits into from
Nov 22, 2024
Merged

Restore as a standalone operation and remove from watch #634

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e4b0840
Don't restore as part of dotnet watch operation
jwthomson Oct 18, 2024
3cc7024
fixed sln name
Larocceau Nov 15, 2024
96b7cad
Make template execution test output more readable
Larocceau Nov 22, 2024
4b8bd1c
Ensure resources are free before running bundle test
Larocceau Nov 22, 2024
82f12f0
restore full solution, only build shared
Larocceau Nov 22, 2024
123f6a3
do allow restore for fable
Larocceau Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Content/default/Build.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,12 @@ Target.create "Azure" (fun _ ->
deployment |> Deploy.execute "SAFE-App" Deploy.NoParameters |> ignore)

Target.create "Run" (fun _ ->
run dotnet [ "restore"; "SAFE.App.sln" ] "."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this when creating a new project from the template? I assume that this will break in most cases as the sln won't be called SAFE.App.sln

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My belief is that the templating will replace this but I will double check and report back!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does do the replace but for the test path I used it did the replace in such a way that the sln path's hyphens were transformed to underscores so it wouldn't work. Will dig into the templating a bit to see if I can figure out how we can avoid this.

run dotnet [ "build" ] sharedPath

[
"server", dotnet [ "watch"; "run" ] serverPath
"client", dotnet [ "fable"; "watch"; "-o"; "output"; "-s"; "--run"; "npx"; "vite" ] clientPath
"server", dotnet [ "watch"; "run"; "--no-restore" ] serverPath
"client", dotnet [ "fable"; "watch"; "--noRestore"; "-o"; "output"; "-s"; "--run"; "npx"; "vite" ] clientPath
]
|> runParallel)

Expand Down
Loading