Add auto-generated collection type descriptions #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 15, 2023 14:14
* Adds description for schema linters that require it. * Adds specs.
dpena-ut
changed the title
knapo
approved these changes
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, motivation and context
To continue the related PR below, this adds descriptions to the collection types. The prior change worked well but the graphql schema linter we're using caught these additional types missing descriptions. I believe this should do the job since the generated collection type objects generated inherit from
GraphQL::Schema::Objectwhich has the description method on it.It also adds some basic specs.
Feel free to suggest a different name for the auto-generated name.
Related issue(s) or PR(s)
#149