Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(persons): improve persons scene copy #27028

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −53
Open

feat(persons): improve persons scene copy #27028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bcff14
feat(persons): improve persons scene copy
thmsobrmlr Dec 18, 2024
e0b792f
Update UI snapshots for `chromium` (1)
github-actions[bot] Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified frontend/__snapshots__/scenes-app-persons-groups--cohorts--dark.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/__snapshots__/scenes-app-persons-groups--cohorts--light.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/__snapshots__/scenes-app-persons-groups--groups--dark.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/__snapshots__/scenes-app-persons-groups--groups--light.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/__snapshots__/scenes-app-persons-groups--persons--dark.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/__snapshots__/scenes-app-persons-groups--persons--light.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 1 addition & 2 deletions frontend/src/queries/nodes/PersonsNode/PersonsSearch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ interface LabelType {
const labels: Record<ActorType, LabelType> = {
person: {
label: 'persons',
description:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is still in reference to the legacy implementation. The current query looks like this:

SELECT id, id, created_at, 1
FROM persons
WHERE or(
    ilike(properties.email, '%QUERY%'), 
    ilike(properties.name, '%QUERY%'), 
    ilike(toString(id), '%QUERY%'), 
    in(id, (SELECT person_id FROM person_distinct_ids WHERE ilike(distinct_id, '%QUERY%')))
)
ORDER BY created_at DESC
LIMIT 101 OFFSET 0

'Search by email or Distinct ID. Email will match partially, for example: "@gmail.com". Distinct ID needs to match exactly.',
description: 'Search by name, email, Person ID or Distinct ID.',
},
group: {
label: 'groups',
Expand Down
8 changes: 5 additions & 3 deletions frontend/src/scenes/persons-management/PersonsManagementScene.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,11 @@ export function PersonsManagementScene(): JSX.Element {
return (
<>
<PageHeader
caption={`A catalog of your product's end users, lists of users who have something in common to use in analytics or feature flags${
showGroupsOptions ? ' and groups' : ''
}.`}
caption={
showGroupsOptions
? 'A catalog of identified persons, groups, and your created cohorts.'
: 'A catalog of identified persons and your created cohorts.'
}
buttons={activeTab?.buttons}
/>

Expand Down
2 changes: 1 addition & 1 deletion frontend/src/scenes/persons-management/personsManagementSceneLogic.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export const personsManagementSceneLogic = kea<personsManagementSceneLogicType>(
{
key: 'persons',
url: urls.persons(),
label: 'People & groups',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just list persons in this tab, no group.

label: 'Persons',
content: <Persons />,
},
{
Expand Down
47 changes: 0 additions & 47 deletions frontend/src/scenes/persons/PersonsSearch.tsx
View file
Open in desktop

This file was deleted.

Loading