Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: processEvent for site apps #27020

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: processEvent for site apps #27020

wants to merge 2 commits into from
+18 −6

Conversation

benjackwhite
Copy link
Contributor

Problem

Site apps don't have processEvent but the code returned it as if it does.

Changes

  • Fixes that

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@mariusandra
Copy link
Collaborator

👍 , though needs an update to posthog/cdp/test/test_site_functions.py. I've also been slowed down by this. Perhaps time to remove the "full source equals" test now that we try running things?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjackwhite @mariusandra