feat: CDP Internal events processor #27007
Open
+421
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjackwhite
changed the title
daibhin
reviewed
Dec 18, 2024
| export type HogFunctionTypeType = | ||
| | 'destination' | ||
| | 'transformation' | ||
| | 'internal-destination' |
There was a problem hiding this comment.
Did we say that the type would be more specific (e.g. error_tracking_alert) and just make the Kafka topic generic. I'm easy either way
Comment on lines
+5
to
+13
| event: z.object({ | ||
| uuid: z.string(), | ||
| event: z.string(), | ||
| // In this context distinct_id should be whatever we want to use if doing follow up things (like tracking a standard event) | ||
| distinct_id: z.string(), | ||
| properties: z.record(z.any()), | ||
| timestamp: z.string(), | ||
| url: z.string().optional(), | ||
| }), |
There was a problem hiding this comment.
You probably have a much better grasp on this than me but are we "hacking the system" in any way by reusing the name event here?
When pushing to Kafka we can absolutely use the event that triggered the error tracking issue to be created as the value for most of these properties but I'm guessing we should be using the issue itself instead. E.g. we should push something like:
...
event: z.object({
uuid: issue.id,
event: "$$error_tracking_issue_created",
distinct_id: uuidv4(),
properties: { name: issue.name, description: issue.description, event: processed_event },
timestamp: issue.created_at,
url: `https://us.posthog.com/error_tracking/${issue.id}`,
}),
The event within properties is totally optional but maybe it'd be worth adding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to trigger CDP destinations via "internal events".
This sets up the internal events stream and service to process it.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?