feat: adding capture events for toggling access control button #26705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surbhi-posthog
force-pushed
the
access_control
branch
from
fc18650 to
ecad106
Compare
|
Adding a separate function to test toggle action |
|
The tests I wrote for this event keeps failing due to mismatch event name. I can keep working on this, but Id like to merge the capture at least so we can start collecting logs on this action |
zlwaterfield
requested changes
Dec 18, 2024
Hmm, not sure what you mean. We should be able to test this fairly easily. Do you want to add the test back and I can help you debug it? |
|
I've added the tests back and verified that they pass locally. Previously the tests were failing, so I want to wait for these to complete before moving forward. |
|
creating a new branch since this got ugly: #27031 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to capture logs when the user toggles on/off access control feature under teams.
Remaining features include:
Changes
Changes only add logs in the backend, no frontend changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
Cloud: Yes
How did you test this code?
Locally verified that the activity monitor showed the events and add tests
