-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor code #235
Open
SkybuckFlying
wants to merge
44
commits into
PascalCoinDev:master
Choose a base branch
from
SkybuckFlying:RefactorCode
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor code #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cannot interact with FRMWallet in frame constructors, FRMWallet is not yet constructed.
Bevels might need some more work.
SkybuckFlying
force-pushed
the
RefactorCode
branch
2 times, most recently
from
December 6, 2021 18:48
299ddb9
to
410073c
Compare
SkybuckFlying
force-pushed
the
RefactorCode
branch
from
December 6, 2021 18:54
410073c
to
2f6053c
Compare
FAccountsGrid moved to TFrameAccountExplorer
Risky initialization of TNetData.NetData.OnBlackListUpdated := OnNetBlackListUpdated; Not yet sure if this works, needs to be tested.
Not yet sure if frames can received windows messages. Needs to be tested.
Calling property TNetData.NetData is unsafe. Which calls TNetData.Create Which calls procedure TECPrivateKey.GenerateRandomPrivateKey(EC_OpenSSL_NID : Word); Which relies on UCrypto which is not yet initialized, Which leads to access violation because UCrypto API routine pointers not loaded. TNetData code moved back to procedure TFRMWallet.FinishedLoadingApp;
To be tested in TestGUIImprovements
SkybuckFlying
force-pushed
the
RefactorCode
branch
from
December 8, 2021 01:19
92d87eb
to
98b6cf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider applying this merge to your source base to reduce complexity and maintainable of UFRMWallet.pas:
Changes made:
Benefits:
Drawbacks:
The code should still be debugged, however I have high confident it will perform exactly the same, though testing it is always wise to see if maybe any call accidently calls an equivalent name however the chance of this happening is very small.
Further re-factoring improvements could be made to the frames in the future.
(Proper author and e-mail set)