Make more classes internal, reduce interface use #3554
Annotations
2 errors and 11 warnings
Test:
ImperatorToCK3.UnitTests/CK3/Characters/CK3CharacterTests.cs#L133
Inconsistent accessibility: parameter type 'ProvinceMapper' is less accessible than method 'CK3CharacterTests.CK3CharacterBuilder.WithProvinceMapper(ProvinceMapper)'
|
Test
Process completed with exit code 1.
|
Setup Dotnet for use with actions
Failed to install dotnet runtime + cli, exit code: 1. cp: cannot create directory '/usr/share/dotnet/host/fxr/8.0.11/': Permission denied
cp: cannot create directory '/usr/share/dotnet/shared/Microsoft.NETCore.App/8.0.11/': Permission denied
dotnet_install: Error: Failed to verify the version of installed `.NET Core Runtime`.
Installation source: https://dotnetcli.azureedge.net/dotnet/Runtime/8.0.11/dotnet-runtime-8.0.11-linux-x64.tar.gz.
Installation location: /usr/share/dotnet.
Report the bug at https://github.com/dotnet/install-scripts/issues.
dotnet_install: Error: `.NET Core Runtime` with version = 8.0.11 failed to install with an error.
|
Test:
ImperatorToCK3/CK3/Characters/DNAFactory.cs#L164
TODO check if this is correctly added to portrait modifiers if needed (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
Test:
ImperatorToCK3/CK3/Characters/DNAFactory.cs#L173
TODO check if this is correctly added to portrait modifiers if needed (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
Test:
ImperatorToCK3/CK3/Characters/DNAFactory.cs#L182
TODO check if this is correctly added to portrait modifiers if needed (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
Test:
ImperatorToCK3/CK3/Characters/DNAFactory.cs#L191
TODO check if this is correctly converted (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
Test:
ImperatorToCK3/CK3/Characters/DNAFactory.cs#L207
TODO check if this is correctly added to portrait modifiers if needed (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
Test:
ImperatorToCK3/CK3/Characters/DNAFactory.cs#L214
TODO check if this is correctly added to portrait modifiers if needed (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
Test:
ImperatorToCK3/CK3/Characters/DNAFactory.cs#L221
TODO check if this is correctly added to portrait modifiers if needed (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
Test:
ImperatorToCK3/CK3/Characters/DNAFactory.cs#L322
TODO CHECK IF BALD CHARACTERS STILL CORRECTLY APPEAR BALD IN CK3 (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
Test:
ImperatorToCK3/CK3/CK3LocDB.cs#L93
TODO add unit test for combining loc from all the sources into one locblock (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
|
Loading