Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add require soft in readme.md #79

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add require soft in readme.md #79

wants to merge 1 commit into from

Conversation

gzchen008
Copy link

add require soft in readme.md

@CLAassistant
Copy link

CLAassistant commented Jun 8, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@benjaminhuo benjaminhuo requested a review from wanjunlei June 8, 2023 09:33
@benjaminhuo
Copy link
Member

You'll need to sigh your commit like this:

git commit -s --amend
git push -f

@gzchen008
Update README.md
2670995 
add require soft in readme.md

Signed-off-by: gzchen008 <[email protected]>
@gzchen008
Copy link
Author

You'll need to sigh your commit like this:

git commit -s --amend
git push -f

done

wanjunlei
wanjunlei reviewed Jun 20, 2023
View reviewed changes
builders/java/README.md
@@ -1,5 +1,12 @@
## Build builder of java


Required soft on your linux
```shell
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pack is needed too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanjunlei wanjunlei wanjunlei left review comments

@benjaminhuo benjaminhuo benjaminhuo left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gzchen008 @CLAassistant @benjaminhuo @wanjunlei