Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using language server protocal requires project.json file present in project #434

Open
LucasBullen opened this issue Jul 10, 2017 · 2 comments

Comments

@LucasBullen
Copy link

When connecting a Java client to the omnisharp-node-client Language Server implementation no output is received without a project.json file present.

The requirements for .NET Core have changed with v2.0.0 replacing project.json files with the MSBuild/csproj format (https://docs.microsoft.com/en-us/dotnet/core/tools/project-json-to-csproj).

In regards to Issue #265, personally it was not whether the project was restored (As I restored the project with a .csproj file and had no output), but if a project.json file was present that enabled completion on my file.

@mickaelistria
Copy link

If I understand correctly, this one depends on #435

@mickaelistria
Copy link

Hurray! I tried the latest release v7.1.2 which uses omnisharp-roslyn 1.23.1 and it worked well on Fedora 26 for projects with *.csproj with a version recent of dotnet-core 2.0 and no dependency on mono!
I believe it's a pretty satisfying result from integrator and user POV, so we can close this issue.
Thanks for your assistance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants