Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugging for RSG dependencies update #1260

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
+13 −11
Draft

Debugging for RSG dependencies update #1260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
297137b
chore(deps): update rocket surgery other
renovate[bot] Jun 15, 2024
870d39f
Enable verbose logging for Restore step
manandre Jun 16, 2024
9b41b47
Use GitVersion attribute
manandre Jun 16, 2024
cb13264
Remove GitVersion.Tool from dotnet tools
manandre Jun 18, 2024
aa7b243
Remove GitVersion.Tool from build dependencies
manandre Jun 18, 2024
17edf7d
Revert "Remove GitVersion.Tool from dotnet tools"
manandre Jun 18, 2024
a2ebd08
Add GitVersion.Tool to build dependencies
manandre Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .build/.build.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="GitVersion.Tool" ExcludeAssets="All" />
<PackageReference Include="ReportGenerator" ExcludeAssets="All" />
<PackageReference Include="Rocket.Surgery.Nuke" />
</ItemGroup>
Expand All @@ -23,4 +22,8 @@
<None Remove="*.csproj.DotSettings;*.ref.*.txt" />
</ItemGroup>

<ItemGroup>
<PackageDownload Include="GitVersion.Tool" Version="[5.12.0]" />
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion .build/Build.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,14 @@
public Target Pack => _ => _.Inherit<ICanPackWithDotNetCore>(x => x.CorePack)
.DependsOn(Clean);

[ComputedGitVersion] public GitVersion GitVersion { get; } = null!;
[GitVersion(NoFetch = true)] public GitVersion GitVersion { get; } = null!;

public Target Clean => _ => _.Inherit<ICanClean>(x => x.Clean);
public Target Restore => _ => _.Inherit<ICanRestoreWithDotNetCore>(x => x.CoreRestore);

public Target Test => _ => _.Inherit<ICanTestWithDotNetCore>(x => x.CoreTest);

public Target NpmInstall => _ => _

Check warning on line 66 in .build/Build.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest) 

Member 'NpmInstall' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)

Check warning on line 66 in .build/Build.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest) 

Member 'NpmInstall' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)

Check warning on line 66 in .build/Build.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest) 

Member 'NpmInstall' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)

Check warning on line 66 in .build/Build.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest) 

Member 'NpmInstall' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)

Check warning on line 66 in .build/Build.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest) 

Member 'NpmInstall' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)

Check warning on line 66 in .build/Build.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest) 

Member 'NpmInstall' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
.Executes(() =>
NpmTasks.NpmCi(s => s
.SetProcessWorkingDirectory(VscodeTestExtensionProjectDirectory)));
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ jobs:
- name: 🎁 Restore
id: restore
run: |
dotnet nuke Restore --skip
dotnet nuke Restore --skip --verbosity Verbose
- name: ⚙ Build
id: build
run: |
Expand Down Expand Up @@ -167,7 +167,7 @@ jobs:
Publish:
needs:
- Build
uses: RocketSurgeonsGuild/actions/.github/workflows/[email protected].3
uses: RocketSurgeonsGuild/actions/.github/workflows/[email protected].10
secrets:
RSG_NUGET_API_KEY: '${{ secrets.RSG_NUGET_API_KEY }}'
RSG_AZURE_DEVOPS: '${{ secrets.RSG_AZURE_DEVOPS }}'
2 changes: 1 addition & 1 deletion .github/workflows/close-milestone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:

# move any issues to that milestone in the event the release is renamed
- name: sync milestones
uses: RocketSurgeonsGuild/actions/[email protected].3
uses: RocketSurgeonsGuild/actions/[email protected].10
with:
default-label: 'mysterious'
github-token: ${{ secrets.OMNISHARP_BOT_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/draft-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
continue-on-error: true

- name: sync milestones
uses: RocketSurgeonsGuild/actions/[email protected].3
uses: RocketSurgeonsGuild/actions/[email protected].10
with:
default-label: 'mysterious'
github-token: ${{ secrets.GITHUB_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-milestone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
continue-on-error: true

- name: sync milestones
uses: RocketSurgeonsGuild/actions/[email protected].3
uses: RocketSurgeonsGuild/actions/[email protected].10
with:
default-label: 'mysterious'
github-token: ${{ secrets.GITHUB_TOKEN }}
7 changes: 3 additions & 4 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
</PropertyGroup>
<ItemGroup>
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="8.0.0" />
<PackageVersion Include="Rocket.Surgery.MSBuild.CI" Version="1.1.5" />
<PackageVersion Include="Rocket.Surgery.MSBuild.SourceLink" Version="1.1.5" />
<PackageVersion Include="Rocket.Surgery.MSBuild.CI" Version="1.2.1" />
<PackageVersion Include="Rocket.Surgery.MSBuild.SourceLink" Version="1.2.1" />
<PackageVersion Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3" />
</ItemGroup>
<!-- Samples -->
Expand All @@ -21,10 +21,9 @@
<PackageVersion Include="System.Threading.Tasks" Version="4.3.0" />
</ItemGroup>
<ItemGroup>
<PackageVersion Include="GitVersion.Tool" Version="5.12.0" />
<PackageVersion Include="JetBrains.ReSharper.CommandLineTools" Version="2024.1.3" />
<PackageVersion Include="ReportGenerator" Version="5.3.6" />
<PackageVersion Include="Rocket.Surgery.Nuke" Version="1.7.4" />
<PackageVersion Include="Rocket.Surgery.Nuke" Version="1.8.35" />
</ItemGroup>
<ItemGroup>
<!-- backwards compat is maintained in Directory.Packages.supports.props -->
Expand Down
Loading