Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add regrid_Sv functionality to be able to regrid Sv dataset #1291

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

lsetiawan
Copy link
Member

Overview

This PR add regridding functionality for existing Sv data

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 95.29412% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 70.38%. Comparing base (8600a59) to head (bb257cc).
Report is 38 commits behind head on dev.

Files Patch % Lines
echopype/commongrid/regrid.py 97.43% 2 Missing ⚠️
echopype/utils/misc.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev    #1291       +/-   ##
===========================================
- Coverage   83.80%   70.38%   -13.42%     
===========================================
  Files          64       11       -53     
  Lines        5705      824     -4881     
===========================================
- Hits         4781      580     -4201     
+ Misses        924      244      -680     
Flag Coverage Δ
unittests 70.38% <95.29%> (-13.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsetiawan lsetiawan requested a review from leewujung March 29, 2024 16:34
@lsetiawan
Copy link
Member Author

@leewujung This is currently a draft PR because I don't have tests for it yet. However, could you please start reviewing the implementation and help me try out different scenarios to make sure I have it implemented correctly? Thanks!

@leewujung
Copy link
Member

@lsetiawan : Could you put in at least a couple test so that it's easier to step through the code? Thanks!

@lsetiawan lsetiawan linked an issue Apr 1, 2024 that may be closed by this pull request
@lsetiawan lsetiawan changed the base branch from dev to main April 9, 2024 16:17
@lsetiawan lsetiawan self-assigned this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Add function to regrid Sv data
3 participants