python311Packages.{shiny, rsconnect_*} #231189
Open
+456
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@onny - how's this? Thanks for the feedback so far. |
ofborg
bot
added
2.status: merge conflict
|
Result of 20 packages built:
|
|
Result of 20 packages built:
|
|
Any feedback is welcome, otherwise this is ready for a merge. Thanks! |
|
@onny - thanks! |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
pbsds
changed the title
pbsds
reviewed
Feb 20, 2024
There was a problem hiding this comment.
Result of nixpkgs-review pr 231189 --eval local run on x86_64-linux 1
2 packages failed to build:
- python311Packages.rsconnect-jupyter
- python311Packages.rsconnect-jupyter.dist
12 packages built:
- python311Packages.contextvars
- python311Packages.contextvars.dist
- python311Packages.htmltools
- python311Packages.htmltools.dist
- python311Packages.rsconnect-python
- python311Packages.rsconnect-python.dist
- python311Packages.shiny
- python311Packages.shiny.dist
- python311Packages.shinywidgets
- python311Packages.shinywidgets.dist
- python312Packages.contextvars
- python312Packages.contextvars.dist
rsconnect-jupyter> E ModuleNotFoundError: No module named 'notebook.base'
There are some systemic issues i only comment on once, please apply the changes to all the added packages.
Please also clean up the git commit history, notably:
contextvarsandshinyare added in the same commit- the final commit silently bumps two deps
Comment on lines
+34
to
+42
| nativeCheckInputs = [ | ||
| pytest | ||
| ]; | ||
|
|
||
| checkPhase = '' | ||
| runHook preCheck | ||
| pytest tests/ | ||
| runHook postCheck | ||
| ''; |
There was a problem hiding this comment.
Suggested change
| nativeCheckInputs = [ | |
| pytest | |
| ]; | |
| checkPhase = '' | |
| runHook preCheck | |
| pytest tests/ | |
| runHook postCheck | |
| ''; | |
| nativeCheckInputs = [ | |
| pytestCheckHook | |
| ]; |
| buildPythonPackage rec { | ||
| pname = "contextvars"; | ||
| version = "2.4"; | ||
| format = "setuptools"; |
There was a problem hiding this comment.
Suggested change
| format = "setuptools"; | |
| pyproject = true; |
A new standard
| # can reenable once upstream updates | ||
| checkPhase = '' | ||
| runHook preCheck | ||
| pytest tests/ --ignore=tests/test_managers.py |
There was a problem hiding this comment.
When using pytestCheckHook you can add additional flags to pytestFlagsArray, but this case can be solved with disabledTests or disabledTestPaths
| checkPhase = '' | ||
| runHook preCheck | ||
| # Needed to avoid /homeless-shelter error | ||
| export HOME=$(mktemp -d) |
There was a problem hiding this comment.
when using pytestCheckHook, this can be moved to preCheck
wegank
added
the
2.status: stale
wegank
added
the
2.status: merge conflict
stale
bot
removed
the
2.status: stale
wegank
added
the
2.status: stale
|
@aucub, why was this closed? |
|
Some packages have been added |
stale
bot
removed
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adding Shiny for Python, Posit Connect packages, and related dependencies.
@alexvorobiev @onny
Things done