SFR-1944: Add error state for PDFReader (#163)

* add error state for PDFReader * update error state prop name
NYPL-Simplified · Jul 5, 2024 · ef925b4 · ef925b4
1 parent ff0a1ed
commit ef925b4
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 2 deletions.
diff --git a/src/PdfReader/index.tsx b/src/PdfReader/index.tsx
@@ -244,6 +244,8 @@ export default function usePdfReader(args: ReaderArguments): ReaderReturn {
     };
   }
 
+  if (state.state === 'ERROR') throw state.error;
+
   // if (isFetching) {
   //   // The Reader is fetching a PDF resource
   //   return {
@@ -283,6 +285,13 @@ export default function usePdfReader(args: ReaderArguments): ReaderReturn {
     });
   };
 
+  const onDocumentLoadError = (error: Error) => {
+    dispatch({
+      type: 'PDF_LOAD_ERROR',
+      error: error,
+    });
+  };
+
   function onRenderSuccess(page: PageProps) {
     if (!page.height || !page.width)
       throw new Error(
@@ -331,7 +340,11 @@ export default function usePdfReader(args: ReaderArguments): ReaderReturn {
             }
           `}
         </style>
-        <Document file={state.resource} onLoadSuccess={onDocumentLoadSuccess}>
+        <Document
+          file={state.resource}
+          onLoadSuccess={onDocumentLoadSuccess}
+          onLoadError={onDocumentLoadError}
+        >
           {isParsed && state.numPages && (
             <>
               {state.settings.isScrolling &&

diff --git a/src/PdfReader/reducer.ts b/src/PdfReader/reducer.ts
@@ -171,6 +171,14 @@ export function makePdfReducer(
             state.pageNumber === -1 ? action.numPages : state.pageNumber,
         };
 
+      case 'PDF_LOAD_ERROR':
+        return {
+          ...state,
+          state: 'ERROR',
+          error: action.error,
+          settings: DEFAULT_SETTINGS,
+        };
+
       case 'SET_SCROLL':
         if (state.state !== 'ACTIVE') {
           return handleInvalidTransition(state, action);

diff --git a/src/PdfReader/types.ts b/src/PdfReader/types.ts
@@ -22,7 +22,14 @@ export type InactiveState = ReaderState &
 export type ActiveState = ReaderState &
   InternalState & { state: 'ACTIVE'; settings: ReaderSettings };
 
-export type PdfState = InactiveState | ActiveState;
+export type ErrorState = ReaderState &
+  InternalState & {
+    state: 'ERROR';
+    error: Error;
+    settings: ReaderSettings;
+  };
+
+export type PdfState = InactiveState | ActiveState | ErrorState;
 
 export type PdfReaderAction =
   | {
@@ -34,6 +41,7 @@ export type PdfReaderAction =
   | { type: 'GO_TO_HREF'; href: string }
   | { type: 'RESOURCE_FETCH_SUCCESS'; resource: { data: Uint8Array } }
   | { type: 'PDF_PARSED'; numPages: number }
+  | { type: 'PDF_LOAD_ERROR'; error: Error }
   | { type: 'SET_SCALE'; scale: number }
   | { type: 'SET_SCROLL'; isScrolling: boolean }
   | { type: 'PAGE_LOAD_SUCCESS'; height: number; width: number }