Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in PrecisionInfo ctor #25

Open
QDanteQ opened this issue Dec 1, 2023 · 2 comments
Open

Typo in PrecisionInfo ctor #25

QDanteQ opened this issue Dec 1, 2023 · 2 comments
Labels
ready Changes made and ready for release. Will close when “done”.

Comments

@QDanteQ
Copy link

QDanteQ commented Dec 1, 2023

include\sl.h(369,40): error : base class 'sl::BaseStructure' is uninitialized when used here to access 'sl::BaseStructure::structType' [-Werror,-Wuninitialized]

You might wanted to pass PrecisionInfo::s_structType instead of BaseStructure::structType in BaseStructure ctor

@jake-nv
Copy link
Collaborator

jake-nv commented Feb 28, 2024

Thanks for reporting this!

Missed the cut-off for the upcoming release, but it will be in a later one.

@jake-nv jake-nv added the ready Changes made and ready for release. Will close when “done”. label Mar 23, 2024
@jake-nv
Copy link
Collaborator

jake-nv commented Jun 5, 2024

We haven’t forgotten about this. This wasn’t in 2.4.10 because it was done after a re-org of sl.h that now can’t be cherry-picked into 2.4.x. It’ll go in with the next mass-integration (likely 2.5 or the equivalent).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Changes made and ready for release. Will close when “done”.
Projects
None yet
Development

No branches or pull requests

2 participants