Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/week compose 07 #13

Open
wants to merge 13 commits into
base: develop-compose
Choose a base branch
from
Open

Conversation

hyoeunjoo
Copy link
Collaborator

@hyoeunjoo hyoeunjoo commented May 31, 2024

πŸ“Œπ˜π˜΄π˜΄π˜Άπ˜¦π˜΄

πŸ“Žπ˜žπ˜°π˜³π˜¬ π˜‹π˜¦π˜΄π˜€π˜³π˜ͺ𝘱𝘡π˜ͺ𝘰𝘯

  • 폴더링 λ‹€μ‹œ ν•˜κΈ΄ ν–ˆλŠ”λ°.. λ­”κ°€ μ΄μƒν•œ 것 κ°™μŠ΅λ‹ˆλ‹€.. μ‹œν—˜ λλ‚˜κ³  λ‹€μ‹œ κ³ μ³λ³Όκ²Œμš”!
  • Repositoryλ₯Ό μ΄μš©ν•΄μ„œ UI와 Data둜직 λΆ„λ¦¬ν–ˆμŠ΅λ‹ˆλ‹€

πŸ“·π˜šπ˜€π˜³π˜¦π˜¦π˜―π˜΄π˜©π˜°π˜΅

ν™”λ©΄ μž‘λ™μ€ κ·Έ μ „κ³Ό λ™μΌν•©λ‹ˆλ‹€. λͺ¨λ‘ μ‹€ν–‰λ©λ‹ˆλ‹€.

πŸ’¬π˜›π˜° π˜™π˜¦π˜·π˜ͺ𝘦𝘸𝘦𝘳𝘴

담주에 μ‹œν—˜μ΄λΌ κΈ‰ν•˜κ²Œ 미리 μ˜¬λ €μ„œ κ³ μΉ  점이 λ§Žμ„ 것 κ°™μŠ΅λ‹ˆλ‹€
μ–Έμ œλ“ μ§€ κ³ μΉ  점 많이 많이 μ–˜κΈ°ν•΄μ£Όμ‹œλ©΄ κ°μ‚¬ν•˜κ² μŠ΅λ‹ˆλ‹€..!!

@hyoeunjoo hyoeunjoo requested review from chanubc, cacaocoffee, OliviaYJH and kez-lab and removed request for chanubc, cacaocoffee and OliviaYJH May 31, 2024 12:12
@hyoeunjoo hyoeunjoo self-assigned this May 31, 2024
Copy link
Member

@OliviaYJH OliviaYJH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜κ³ ν–ˆμ–΄μš”!!

private val authRepository: AuthRepository,
) : ViewModel() {

val loginResult: MutableLiveData<Boolean> = MutableLiveData()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
val loginResult: MutableLiveData<Boolean> = MutableLiveData()
private val _loginResult = MutableLiveData<Boolean>()
val loginResult: LiveData<Boolean> get() = _loginResult

μ΄λ ‡κ²Œ μž‘μ„±ν•΄μ„œ _loginResultλŠ” ViewModelμ—μ„œλ§Œ μˆ˜μ • κ°€λŠ₯ν•˜κ²Œ ν•˜κ³  activityμ—μ„œλŠ” loginResult에 μ ‘κ·Όλ§Œ κ°€λŠ₯ν•  수 있게 ν•˜λ©΄ 쒋을 것 κ°™μ•„μš”!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errorMessage도 λ§ˆμ°¬κ°€μ§€ μ—μš”!!

Copy link
Member

@chanubc chanubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 6μ£Όμ°¨ 머지 되면 λ‹€μ‹œ 봐볼게용
ν•œν•™κΈ°λ™μ•ˆ λ„ˆλ¬΄ κ³ μƒν–ˆμ–΄μš”
μ§„μ§œ 일.μ·¨.μ›”.μž₯!!!

κ³ λ§ˆμ›Œγ… γ… 

private val authRepository: AuthRepository,
) : ViewModel() {

val loginResult: MutableLiveData<Boolean> = MutableLiveData()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errorMessage도 λ§ˆμ°¬κ°€μ§€ μ—μš”!!

Comment on lines +8 to +18
class LoginViewModelFactory : ViewModelProvider.Factory {
override fun <T : ViewModel> create(modelClass: Class<T>): T {
if (modelClass.isAssignableFrom(LoginViewModel::class.java)) {
val repository =
AuthRepoImpl(ServicePool.authService)
return LoginViewModel(repository) as T
} else {
throw IllegalArgumentException("Failed to create ViewModel: ${modelClass.name}")
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

factory λ·°λͺ¨λΈ λ§ˆλ‹€ λ§Œλ“€ν•„μš” 없이 ν•˜λ‚˜λ‘œ ν•©μ³μ£Όμ„Έμš”!
ν™•μž₯μ„±κ³Ό 쀑앙 집쀑화과 되기 λ•Œλ¬Έμ— 더 νš¨μœ¨μ μž…λ‹ˆλ‹€
μ‹œν—˜ λλ‚˜λ©΄ μžμ„Έν•˜κ²Œ μ•Œλ €λ“œλ¦΄κ²Œμš©

Comment on lines +22 to +25
var signUpId = mutableStateOf("")
var signUpPw = mutableStateOf("")
var signUpName = mutableStateOf("")
var signUpPhone = mutableStateOf("")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var signUpId = mutableStateOf("")
var signUpPw = mutableStateOf("")
var signUpName = mutableStateOf("")
var signUpPhone = mutableStateOf("")
var id by rememberSaveable { mutableStateOf("") }
var password by rememberSaveable { mutableStateOf("") }
var nickName by rememberSaveable { mutableStateOf("") }
var mbti by rememberSaveable { mutableStateOf("") }

by rememberν‚€μ›Œλ“œλ₯Ό 톡해 객체λ₯Ό 생성후 μƒλœ 객체λ₯Ό κΈ°μ–΅ν•˜κ³  μž¬μ‚¬μš© ν•  수 μžˆμŠ΅λ‹ˆλ‹€!
μ»΄ν¬μ¦ˆμ—μ„œμ˜ μƒνƒœκ΄€λ¦¬ νŒ¨ν„΄μ΄μ—μ—¬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants