feat: Refactor inventory #324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# List of changes:
- Completed InventoryIterator to match the spec
- Improved the Inventory interface
- Completed JavaDoc
- Now uses `java.util.Optional` instead of `null`
- Methods now throw `java.lang.IndexOutOfBoundsException`
if the requested slot is out of bounds
ExE-Boss
added
the
in progress
ExE-Boss
added
feature
breaking change
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
============================================
- Coverage 13.24% 13.21% -0.03%
- Complexity 1005 1006 +1
============================================
Files 532 532
Lines 17368 17429 +61
Branches 1803 1818 +15
============================================
+ Hits 2301 2304 +3
- Misses 14920 14978 +58
Partials 147 147
Continue to review full report at Codecov.
|
|
The original rule of thumb was that we accept nulls into arguments and return optionals. |
ExE-Boss
force-pushed
the
refactor/inventory
branch
from
f942ebc to
18ac33a
Compare
ExE-Boss
force-pushed
the
refactor/inventory
branch
2 times, most recently
from
3606bc2 to
ff59b33
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes:
Now usesjava.util.Optionalinstead ofnulljava.lang.IndexOutOfBoundsExceptionif the requested slot is out of bounds (fixes BWInventory may throw IOOBE for cases where Inventory doesn't. #188)