Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FakeWorld.getEntities() #312

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ExE-Boss
Copy link
Member

This PR finishes the FakeWorld.getEntities(...) implementation.

@ExE-Boss ExE-Boss added the done Pull requests that are finished and are ready to be reviewed and merged label Oct 23, 2017
@ExE-Boss ExE-Boss self-assigned this Oct 23, 2017
@ExE-Boss ExE-Boss requested a review from RX14 October 23, 2017 22:44
@codecov-io
Copy link

Codecov Report

Merging #312 into master will decrease coverage by 0.8%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #312      +/-   ##
============================================
- Coverage     16.99%   16.18%   -0.81%     
- Complexity      965      975      +10     
============================================
  Files           416      416              
  Lines         13165    13969     +804     
  Branches       1383     1472      +89     
============================================
+ Hits           2237     2261      +24     
- Misses        10782    11560     +778     
- Partials        146      148       +2
Impacted Files Coverage Δ Complexity Δ
.../java/nova/core/block/component/BlockProperty.java 61.53% <0%> (-38.47%) 0% <0%> (ø)
.../wrapper/mc/forge/v18/wrapper/VectorConverter.java 71.42% <0%> (-16.08%) 10% <0%> (+3%)
.../mc/forge/v17/wrapper/item/ItemWrapperMethods.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...e/v18/wrapper/block/backward/BWBlockTransform.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...per/mc/forge/v17/wrapper/block/BlockConverter.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...core/wrapper/mc/forge/v17/asm/StaticForwarder.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...apper/mc/forge/v17/wrapper/item/BWItemFactory.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
.../forge/v17/wrapper/block/forward/FWBlockSound.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...apper/mc/forge/v17/launcher/ForgeEventHandler.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
.../mc/forge/v18/wrapper/entity/forward/FWEntity.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 297857e...a527fae. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #312 into master will decrease coverage by 0.8%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #312      +/-   ##
============================================
- Coverage     16.99%   16.18%   -0.81%     
- Complexity      965      975      +10     
============================================
  Files           416      416              
  Lines         13165    13969     +804     
  Branches       1383     1472      +89     
============================================
+ Hits           2237     2261      +24     
- Misses        10782    11560     +778     
- Partials        146      148       +2
Impacted Files Coverage Δ Complexity Δ
.../java/nova/core/block/component/BlockProperty.java 61.53% <0%> (-38.47%) 0% <0%> (ø)
.../wrapper/mc/forge/v18/wrapper/VectorConverter.java 71.42% <0%> (-16.08%) 10% <0%> (+3%)
...forge/v17/wrapper/block/forward/ProxyMaterial.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...per/mc/forge/v17/wrapper/block/BlockConverter.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...apper/mc/forge/v18/launcher/ForgeEventHandler.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
.../mc/forge/v17/wrapper/item/ItemWrapperMethods.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...apper/mc/forge/v18/wrapper/item/BWItemFactory.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
.../mc/forge/v18/wrapper/entity/forward/FWEntity.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
.../mc/forge/v18/wrapper/item/ItemWrapperMethods.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...mc/forge/v18/network/discriminator/NovaPacket.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 297857e...a527fae. Read the comment docs.

@ExE-Boss ExE-Boss added in progress Pull requests that are not yet ready to be merged and issues that are being worked on. and removed done Pull requests that are finished and are ready to be reviewed and merged labels Oct 23, 2017
@ExE-Boss ExE-Boss removed the request for review from RX14 October 23, 2017 22:49
@ExE-Boss ExE-Boss added the enhancement Nice to have features label Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Nice to have features in progress Pull requests that are not yet ready to be merged and issues that are being worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants