New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BWInventory may throw IOOBE for cases where Inventory doesn't. #188

Open

SoniEx2 opened this issue Sep 9, 2015 · 0 comments · May be fixed by #324

Assignees

Labels

enhancement in progress

Contributor

SoniEx2 commented Sep 9, 2015

BWInventory may throw IOOBE for cases where Inventory doesn't.

https://github.com/NOVA-Team/NOVA-Core/blob/master/minecraft/1.7/src/main/java/nova/core/wrapper/mc17/wrapper/inventory/BWInventory.java#L20

Vanilla inventories (e.g. vanilla furnace) are guilty of this: They don't bounds-check.

calclavia added the enhancement label

ExE-Boss linked a pull request

that will close this issue

feat: Refactor inventory #324

Open

ExE-Boss self-assigned this

ExE-Boss added the in progress label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment