Attempt to give more context on unknown record type zone file parsing errors. #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… errors. Doesn't fully extend `StrError` as in my scenario I don't seem to use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came about because I encountered error messages like:
Which record type? If I have access to the source file still at the time of inspecting the error then I can determine the RTYPE from the input file, but if the file is gone or was never available due to being XFR or taken from a database or something then the lack of the actual RTYPE is quite annoying.
I suspect this is a breaking change, as I think the zone file parsing was released before we added unstable support for parsing into a zone tree.
Note: This PR doesn't fully extend
StrErroras in my scenario I don't seem to use it, perhaps we should augment that more, and doesn't update any tests.