Add support for CAA record type #434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ximon18 The Caa |
partim
reviewed
Dec 18, 2024
| @@ -380,6 +380,22 @@ impl<Octs: AsRef<[u8]> + ?Sized> CharStr<Octs> { | |||
| .compose(target)?; | |||
| target.append_slice(self.0.as_ref()) | |||
| } | |||
|
|
|||
| /// Appends the canonical wire format representation to an octets builder. | |||
| pub fn compose_canonical<Target: OctetsBuilder + ?Sized>( | |||
There was a problem hiding this comment.
I think this method produces the same result as compose only slower?
I don’t think we need an extra method here – I think using compose is actually better since it makes it clear that we don’t do anything special. (This is less important for char strings that don’t anything special, but for domain names it is important to signal that they are not lower cased and for consistency, using the same strategy here seems better to me.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#271