v4

[linkdotnet]

This PR will hold all new features for v4. When merged to main - we will release it to the wild.
Preview release have to be released from this branch!

Additional (All the features/changes for v4)

This PR includes:

• Optionally make startup jobs run early #111
• Make IRuntimeJobRegistry API less "redundant" when registering a new Job #122
• Add CHANGELOG entries for v4 before release #126
• Deal with duplicates in a uniform manner #128
• Make UseNCronJobAsync() mandatory when startup jobs have been defined #136

[nulltoken]

@linkdotnet What's the plan to reintroduce v3 changes into this branch?

[linkdotnet]

I will rebase the v4 with the current master - so we will have all the changes.
if there are too many things going on on v4 maybe I’ll switch to merge instead of rebase

[nulltoken]

I will rebase the v4 with the current master - so we will have all the changes.
if there are too many things going on on v4 maybe I’ll switch to merge instead of rebase

Thx. That'd be helpful. I have started a WIP on the "detection of ambiguous jobDefinitions" (portions of #108 discussion with a v4 target in mind) and I need some portions of #124 (v3) to progress further.

[linkdotnet]

I will rebase the v4 with the current master - so we will have all the changes.
if there are too many things going on on v4 maybe I’ll switch to merge instead of rebase

Thx. That'd be helpful. I have started a WIP on the "detection of ambiguous jobDefinitions" (portions of #108 discussion with a v4 target in mind) and I need some portions of #124 (v3) to progress further.

I will rebase main after your 2 PR's are merged and hopefully my open one as well :D

[nulltoken]

and hopefully my open one as well :D

Yep, I'd also need this one for the ambiguous detection WIP.

[linkdotnet]

@nulltoken Rebase done

EDIT: We can also probably "freeze" v3. So that we don't develop any more features. Only if there is a really urgent bugfix, I would argue we should tackle. Otherwise we make our lives harder :D

EDIT 2: That said, your changes should go live, I assume? Therefore I would make a new release.

[codecov]

Codecov Report

Attention: Patch coverage is 94.28571% with 4 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...Job/Configuration/Builder/NCronJobOptionBuilder.cs	72.72%	2 Missing and 1 partial ⚠️
src/NCronJob/NCronJobExtensions.cs	95.23%	1 Missing ⚠️

Files with missing lines	Coverage Δ
...ronJob/Configuration/MissingMethodCalledHandler.cs	100.00% <100.00%> (ø)
src/NCronJob/Registry/IInstantJobRegistry.cs	90.56% <ø> (ø)
src/NCronJob/Registry/JobRegistry.cs	95.87% <100.00%> (+4.66%)	⬆️
src/NCronJob/Registry/RuntimeJobRegistry.cs	97.22% <100.00%> (+0.25%)	⬆️
src/NCronJob/Scheduler/QueueWorker.cs	70.58% <100.00%> (+6.37%)	⬆️
src/NCronJob/NCronJobExtensions.cs	97.36% <95.23%> (-2.64%)	⬇️
...Job/Configuration/Builder/NCronJobOptionBuilder.cs	88.28% <72.72%> (+1.88%)	⬆️

... and 5 files with indirect coverage changes

[nulltoken]

EDIT 2: That said, your changes should go live, I assume? Therefore I would make a new release.

I'd love to be able to benefit from #132 before v4 ;-)

[nulltoken]

EDIT: We can also probably "freeze" v3. So that we don't develop any more features. Only if there is a really urgent bugfix, I would argue we should tackle. Otherwise we make our lives harder :D

Deal.

[linkdotnet]

EDIT 2: That said, your changes should go live, I assume? Therefore I would make a new release.

I'd love to be able to benefit from #132 before v4 ;-)

Release is on the way