Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ecr endpoint #432

Merged
merged 5 commits into from
Oct 15, 2024
Merged

feat: add ecr endpoint #432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
385eba4
add ecr endpoint
smohiudd Oct 3, 2024
d64d42d
format
smohiudd Oct 3, 2024
a92e0a5
Add dkr endpoint for ECR
ividito Oct 3, 2024
199c871
Add ECR endpoints to standalone network
ividito Oct 3, 2024
e3c4ec2
Add STS endpoint
ividito Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions network/infrastructure/construct.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ def __init__(
"cloudwatch-logs": aws_ec2.InterfaceVpcEndpointAwsService.CLOUDWATCH_LOGS,
"s3": aws_ec2.GatewayVpcEndpointAwsService.S3,
"dynamodb": aws_ec2.GatewayVpcEndpointAwsService.DYNAMODB,
"ecr": aws_ec2.InterfaceVpcEndpointAwsService.ECR,
"ecr-docker": aws_ec2.InterfaceVpcEndpointAwsService.ECR_DOCKER,
"sts": aws_ec2.InterfaceVpcEndpointAwsService.STS,
}
ividito marked this conversation as resolved.
Show resolved Hide resolved

for id, service in vpc_endpoints.items():
Expand Down
3 changes: 3 additions & 0 deletions standalone_base_infrastructure/network_construct.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ def __init__(
"cloudwatch-logs": aws_ec2.InterfaceVpcEndpointAwsService.CLOUDWATCH_LOGS,
"s3": aws_ec2.GatewayVpcEndpointAwsService.S3,
"dynamodb": aws_ec2.GatewayVpcEndpointAwsService.DYNAMODB,
"ecr": aws_ec2.InterfaceVpcEndpointAwsService.ECR, # allows airflow to pull task images
"ecr-docker": aws_ec2.InterfaceVpcEndpointAwsService.ECR_DOCKER, # allows airflow to pull task images
"sts": aws_ec2.InterfaceVpcEndpointAwsService.STS, # allows airflow tasks to assume access roles
}

for id, service in vpc_endpoints.items():
Expand Down