feat: remove cloudfront distribution and custom alternate domain from backend #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botanical
changed the title
botanical
requested review from
anayeaye,
slesaad,
ciaransweet,
ividito,
amarouane-ABDELHAK and
smohiudd
ciaransweet
approved these changes
Aug 19, 2024
|
Going to hold off on merging this until after next release |
smohiudd
reviewed
Aug 22, 2024
app.py
Outdated
| @@ -120,23 +104,27 @@ def __init__(self, scope: Construct, construct_id: str, **kwargs) -> None: | |||
| db_secret_name = database.pgstac.secret.secret_name | |||
| db_security_group = database.db_security_group | |||
|
|
|||
| base_api_url = f"https://{veda_app_settings.stage_name()}.{veda_app_settings.veda_custom_host}".strip( | |||
There was a problem hiding this comment.
Doesn't VEDA_CUSTOM_HOST already include the stage name?
anayeaye
reviewed
Aug 22, 2024
app.py
Outdated
| # ingestor config requires references to other resources, but can be shared between ingest api and bulk ingestor | ||
| ingestor_config = ingest_config( | ||
| stage=veda_app_settings.stage_name(), | ||
| stac_db_security_group_id=db_security_group.security_group_id, | ||
| stac_api_url=stac_api.stac_api.url, | ||
| raster_api_url=raster_api.raster_api.url, | ||
| stac_api_url=stac_api_url, |
There was a problem hiding this comment.
I think we could handle inferring the cloudfront urls in config with a property or function
@property
def veda_stac_api_cf_url(self) -> str:
"""inferred cloudfront url of the stac api if app is configured with a custom host and root path"""
if self.veda_custom_host and self.veda_stac_root_path:
return f"https://{self.veda_custom_host}{self.veda_stac_root_path}"
return None
and then conditionally use them here so that we have a way to use the API gateway url if a cloudfront is not used.
stac_api_url=settings.stac_api_cf_url if settings.stac_api_cf_url else stac_api.stac_api.url
smohiudd
approved these changes
Aug 23, 2024
anayeaye
reviewed
Aug 23, 2024
There was a problem hiding this comment.
Sorry I didn't hit send on these yesterday. The only change I think we might need is the suggestion about handling both api gateway urls and cloudfront urls #422 (comment)
| veda_routes.create_route_records(stage=veda_app_settings.stage_name()) | ||
|
|
||
|
|
||
| # TODO this conditional supports deploying a second set of APIs to a separate custom domain and should be removed if no longer necessary |
1 task
anayeaye
approved these changes
Aug 23, 2024
1 task
anayeaye
added a commit
that referenced
this pull request
Oct 15, 2024
…lidation, add nlcd colormap (#434) **Breaking** feat(routes)!: remove cloudfront distribution and custom alternate domain from backend #422 **Added** feat(raster-api): added custom NLCD colormap #433 feat: add ecr endpoint #432 **Fixed** fix(tests): #425 fix(ingest): improved datetime validations #419 **Changed** ci: remove automated deployments to staging #438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#403
#221
What + Why
Testing?
Deployed to UAH