-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Make pypgstac an ENV in dockerfile #404
chore: Make pypgstac an ENV in dockerfile #404
Conversation
ingest_api/runtime/requirements.txt
Outdated
@@ -8,7 +8,7 @@ orjson>=3.6.8 | |||
psycopg[binary,pool]>=3.0.15 | |||
pydantic_ssm_settings>=0.2.0 | |||
pydantic>=1.10.12 | |||
pypgstac==0.7.4 | |||
pyjwt>=2.8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this came from merging upstream develop changes. The same line and same first two characters confused the merge conflict resolver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for pointing this out! I got rid of pyjwt
.. because looks like it was no longer in the develop
branch and added pypgstac
back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I guess we get it here now https://github.com/NASA-IMPACT/veda-backend/blob/develop/common/auth/setup.py#L6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we still do need - pypgstac==0.7.4
@sandrahoang686 I took the liberty of pulling recent changes from develop into your branch and making this small change to get the pgstac_version in the build api parameters. I can see that worked in the action because the docker build is now installing the correct version |
@anayeaye I've passed in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the correct pypgstac installed in the github action log as well as Code updates for both the ingest api handler and the ingestor construct.
@sandrahoang686 you could do a local cdk synth and look at the outputs but I think the easiest way to verify this kind of change is to read the pre-deploy job associated with this PR. I searched to be sure that the correct pypgstac was installed in both ingest lambda Dockerfile builds. |
Issue
#372
What?
Make pypgstac and ENV var in dockerfile
Why?
Testing?
Deployed without any errors to http://monitor.openveda.cloud/