Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support transactions with validation and authentication #378

Merged
merged 63 commits into from
Aug 6, 2024
Merged

feat: support transactions with validation and authentication #378

merged 63 commits into from
Aug 6, 2024

Conversation

slesaad
Copy link
Member

@slesaad slesaad commented May 22, 2024 •
edited
Loading

Issue

#295

What?

  • Add transactions extensions from - feat: enable transactions extension for demo #276
  • Add bulk transactions extension
  • Add authentication for all transactions PUT POST endpoints
  • Add authentication to openapi docs
  • Add request validation to all all transactions PUT POST endpoints

Why?

  • To allow stac editing (collection and item) + enable stac-admin

Testing?

TODO

  • Refactor the way env vars are used
  • Remove temporary workflow
  • Fix failing tests
  • Use pystac instead of stac_pydantic
  • Make transactions a feature flag
  • Package auth?
    - [ ] Tests (to be handled in a separate ticket)

@slesaad slesaad changed the title WIP: Authentication + Validation in transactions endpoint feat: support transactions with validation and authentication May 22, 2024
@slesaad slesaad requested review from anayeaye and smohiudd May 22, 2024 22:06
@slesaad slesaad marked this pull request as ready for review May 22, 2024 22:06
@smohiudd
Copy link
Contributor

smohiudd commented Jul 26, 2024 •
edited
Loading

I was able to authenticate myself and try out all the transactions endpoints. The validation is also working well for collections and items. This is looking good!

@slesaad slesaad mentioned this pull request Aug 5, 2024
Open
1 task
@slesaad slesaad merged commit 3b4b495 into develop Aug 6, 2024
4 checks passed
@slesaad slesaad deleted the full-transaction-support branch August 6, 2024 14:59
@smohiudd smohiudd mentioned this pull request Aug 6, 2024
Open
4 tasks
@botanical botanical mentioned this pull request Aug 6, 2024
Merged
smohiudd pushed a commit that referenced this pull request Aug 14, 2024
@botanical @slesaad
@sandrahoang686 @anayeaye @ciaransweet
feat(release): support transactions with validation and authentication (
c89608f 
#378), add auth requirements install for ingest-api tests (#415), update .example.env and README (#412) (#416)

Co-authored-by: Slesa Adhikari <[email protected]>
Co-authored-by: Sandra Hoang <[email protected]>
Co-authored-by: Alexandra Kirk <[email protected]>
Co-authored-by: Ciaran Sweet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alukach alukach alukach left review comments

@smohiudd smohiudd smohiudd approved these changes

@anayeaye anayeaye Awaiting requested review from anayeaye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slesaad @smohiudd @alukach @anayeaye