Skip to content

Commit

Permalink
feat: disable default api gateway endpoints (#443)
Browse files Browse the repository at this point in the history
### Issue

NASA-IMPACT/veda-architecture#452

### What/Why
This disables the default API Gateway endpoints for the stac, raster,
and ingest APIs. Instead, access to the APIs should be done through the
custom domain endpoints.

#### Testing
Tested with my UAH jtran stack
  • Loading branch information
botanical authored Oct 23, 2024
2 parents b633276 + da2d01e commit aa3292e
Show file tree
Hide file tree
Showing 8 changed files with 24 additions and 0 deletions.
1 change: 1 addition & 0 deletions .example.env
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,4 @@ VEDA_CLOUDFRONT=
VEDA_CLOUDFRONT_OAC=[OPTIONAL, CONFIGURES ORIGIN ACCESS CONTROL, DEFAULTS TO TRUE]
VEDA_CUSTOM_HOST=
VEDA_SHARED_WEB_ACL_ID=[OPTIONAL ID ARN for WEB ACL]
VEDA_DISABLE_DEFAULT_APIGW_ENDPOINT=[OPTIONAL BOOL TO DISABLE DEFAULT API GATEWAY ENDPOINTS]
5 changes: 5 additions & 0 deletions config.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,11 @@ class vedaAppSettings(BaseSettings):
None, description="Custom domain name, i.e. veda-backend.xyz"
)

disable_default_apigw_endpoint: Optional[bool] = Field(
False,
description="Boolean to disable default API gateway endpoints for stac, raster, and ingest APIs. Defaults to false.",
)

def cdk_env(self) -> dict:
"""Load a cdk environment dict for stack"""

Expand Down
5 changes: 5 additions & 0 deletions ingest_api/infrastructure/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,11 @@ class IngestorConfig(BaseSettings):
description="Raster API root path. Used to infer url of raster-api before app synthesis.",
)

disable_default_apigw_endpoint: Optional[bool] = Field(
False,
description="Boolean to disable default API gateway endpoints for stac, raster, and ingest APIs. Defaults to false.",
)

class Config:
case_sensitive = False
env_file = ".env"
Expand Down
3 changes: 3 additions & 0 deletions ingest_api/infrastructure/construct.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ def __init__(
construct_id=construct_id,
handler=self.api_lambda,
custom_host=config.custom_host,
disable_default_apigw_endpoint=config.disable_default_apigw_endpoint,
)

stack_name = Stack.of(self).stack_name
Expand Down Expand Up @@ -188,6 +189,7 @@ def build_api(
construct_id: str,
handler: aws_lambda.IFunction,
custom_host: Optional[str],
disable_default_apigw_endpoint: Optional[bool],
) -> aws_apigatewayv2_alpha.HttpApi:
integration_kwargs = dict(handler=handler)
if custom_host:
Expand All @@ -211,6 +213,7 @@ def build_api(
self,
f"{stack_name}-{construct_id}",
default_integration=ingest_api_integration,
disable_execute_api_endpoint=disable_default_apigw_endpoint,
)

def build_jwks_url(self, userpool_id: str) -> str:
Expand Down
4 changes: 4 additions & 0 deletions raster_api/infrastructure/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@ class vedaRasterSettings(BaseSettings):
"VEDA (Visualization, Exploration, and Data Analysis)",
description="Name of the STAC Catalog",
)
disable_default_apigw_endpoint: Optional[bool] = Field(
False,
description="Boolean to disable default API gateway endpoints for stac, raster, and ingest APIs. Defaults to false.",
)

class Config:
"""model config"""
Expand Down
1 change: 1 addition & 0 deletions raster_api/infrastructure/construct.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ def __init__(
self,
f"{stack_name}-{construct_id}",
default_integration=raster_api_integration,
disable_execute_api_endpoint=veda_raster_settings.disable_default_apigw_endpoint,
)

CfnOutput(
Expand Down
4 changes: 4 additions & 0 deletions stac_api/infrastructure/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ class vedaSTACSettings(BaseSettings):
stac_enable_transactions: bool = Field(
False, description="Whether to enable transactions endpoints"
)
disable_default_apigw_endpoint: Optional[bool] = Field(
False,
description="Boolean to disable default API gateway endpoints for stac, raster, and ingest APIs. Defaults to false.",
)

@root_validator
def check_transaction_fields(cls, values):
Expand Down
1 change: 1 addition & 0 deletions stac_api/infrastructure/construct.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ def __init__(
self,
f"{stack_name}-{construct_id}",
default_integration=stac_api_integration,
disable_execute_api_endpoint=veda_stac_settings.disable_default_apigw_endpoint,
)

CfnOutput(
Expand Down

0 comments on commit aa3292e

Please sign in to comment.